Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escaped characters in INI values are not unescaped #3648

Closed
ProjectPatatoe opened this issue Dec 10, 2018 · 5 comments

Comments

@ProjectPatatoe
Copy link

commented Dec 10, 2018

When editing / entering a LDAP resource, I run into issues with escape characters for "Bind DN". Normally it would be CN=Smith\, John,OU=blah ... and so on. It validates as OK.
However when I save it, it gets saved as CN=Smith\\, John,OU=blah ... and so on and this is now "Invalid Credentials" because of the extra \

My current work around is to edit /etc/icingaweb2/resources.ini and fix it there.

Your Environment

  • Icinga Web 2 version and modules (System - About): 2.6.2
  • Version used (icinga2 --version): r2.10.2-1
  • Operating System and version: 18.04.1 LTS
@nilmerg

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

Hi,

just don't escape anything? Doesn't it work without it?

I suppose the reason you think you'll need to escape commas here is due to something else that's also processing the bind dn. Though, Icinga Web 2 does not and passes it right through to LDAP which shouldn't care about commas here as it's the standard separator in distinguished names.

@ProjectPatatoe

This comment has been minimized.

Copy link
Author

commented Dec 11, 2018

without escaping it. (CN=Smith, John,OU=blah...) it fails to validate with "Invalid Credentials"

@nilmerg

This comment has been minimized.

Copy link
Member

commented Dec 12, 2018

Oh, I see. It's in your username where it certainly needs to be escaped. My bad.

@trendchiller

This comment has been minimized.

Copy link

commented Dec 14, 2018

same error here

@carraroj

This comment has been minimized.

Copy link

commented Jan 23, 2019

ref/IP/11051

@nilmerg nilmerg self-assigned this Jan 31, 2019

@nilmerg nilmerg added this to the 2.7.0 milestone Jan 31, 2019

nilmerg added a commit that referenced this issue Feb 1, 2019

nilmerg added a commit that referenced this issue Feb 1, 2019

nilmerg added a commit that referenced this issue Feb 1, 2019

nilmerg added a commit that referenced this issue Feb 1, 2019

lippserd added a commit that referenced this issue Feb 5, 2019

IniParser: Properly unescape special characters in section names and …
…option values

refs #3648

Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>

lippserd added a commit that referenced this issue Feb 5, 2019

ConfigForm: Only render valid configurations in the ui
refs #3648

Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>

lippserd added a commit that referenced this issue Feb 5, 2019

DashletForm: Make sure that we won't try to save invalid section names
refs #3648

Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>

lippserd added a commit that referenced this issue Feb 5, 2019

IniParser: Properly unescape special characters in section names and …
…option values

refs #3648

Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>

lippserd added a commit that referenced this issue Feb 5, 2019

ConfigForm: Only render valid configurations in the ui
refs #3648

Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>

lippserd added a commit that referenced this issue Feb 5, 2019

DashletForm: Make sure that we won't try to save invalid section names
refs #3648

Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>

theFeu pushed a commit that referenced this issue Mar 22, 2019

IniParser: Properly unescape special characters in section names and …
…option values

refs #3648

Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>

theFeu pushed a commit that referenced this issue Mar 22, 2019

ConfigForm: Only render valid configurations in the ui
refs #3648

Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>

theFeu pushed a commit that referenced this issue Mar 22, 2019

DashletForm: Make sure that we won't try to save invalid section names
refs #3648

Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>

@nilmerg nilmerg modified the milestones: 2.7.0, 2.6.3 Apr 17, 2019

@nilmerg nilmerg changed the title LDAP escape character for comma Escaped characters in INI values are not unescaped Apr 24, 2019

@nilmerg nilmerg added the ref/IP label May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.