Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't translate pane and dashlet names in configs #3837

Merged

Conversation

@nilmerg
Copy link
Member

commented Jun 26, 2019

Introduces a major breaking change. All non-english users need to adjust their dashboard.ini after this change. (In case they've adjusted dashlets provided by modules)

Missing:

  • Upgrade documentation

fixes #3542

@nilmerg nilmerg added this to the 2.7.0 milestone Jun 26, 2019

doc/80-Upgrading.md Outdated Show resolved Hide resolved
@lippserd

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

We should provide a migrate command for this instead of having users to do this on their own.

@nilmerg nilmerg force-pushed the fix/dont-translate-pane-and-dashlet-names-in-configs-3542 branch from cac9d2c to d4c8eae Jun 27, 2019

@nilmerg nilmerg requested a review from lippserd Jul 11, 2019

nilmerg added some commits Jun 26, 2019

dashboard: Differentiate between `name` and `title`
The former is the original name while title may
be changed by the user. This change is strictly
necessary for the references bug and should also
be introduced when rewriting this mess.

refs #3542
dashboard: Use the non-translated versions of pane and dashlet names …
…for storage

This is a dirty quick fix. And calling it *quick* is already an overstatement.
Of course, it's also a breaking change, as **all** non-english users need to
update their dashboard.ini after this change.

Oh, and don't dare to move this over to the new dashboards!

refs #3542

@nilmerg nilmerg force-pushed the fix/dont-translate-pane-and-dashlet-names-in-configs-3542 branch from d4c8eae to 40ab96b Jul 18, 2019

@nilmerg nilmerg removed the request for review from lippserd Jul 18, 2019

@nilmerg nilmerg merged commit 8d09279 into master Jul 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nilmerg nilmerg deleted the fix/dont-translate-pane-and-dashlet-names-in-configs-3542 branch Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.