Skip to content

Mssql: Implement offset/limit support#20

Closed
Thomas-Gelf wants to merge 1 commit into
masterfrom
feature/row-limit-offset-19
Closed

Mssql: Implement offset/limit support#20
Thomas-Gelf wants to merge 1 commit into
masterfrom
feature/row-limit-offset-19

Conversation

@Thomas-Gelf
Copy link
Copy Markdown
Contributor

@Thomas-Gelf Thomas-Gelf commented Jun 3, 2020

fixes #19

@Thomas-Gelf
Copy link
Copy Markdown
Contributor Author

Thomas-Gelf commented Jun 3, 2020

Concerns:

  • naming. Feel free to suggest better names ;-)
  • needed to extend the Adapter interface. Other upcoming features might be required to do the same. Not sure how this could be solved

@Thomas-Gelf Thomas-Gelf requested a review from lippserd June 3, 2020 07:16
@Thomas-Gelf Thomas-Gelf force-pushed the feature/row-limit-offset-19 branch from f9f4500 to 07d62b9 Compare June 3, 2020 07:17
@Thomas-Gelf Thomas-Gelf force-pushed the feature/row-limit-offset-19 branch from 07d62b9 to 9cd486c Compare June 3, 2020 07:29
@lippserd
Copy link
Copy Markdown
Member

lippserd commented Jun 4, 2020

I opt for #23

@lippserd lippserd closed this Jun 4, 2020
@lippserd lippserd added the duplicate This issue or pull request already exists label Jun 4, 2020
@lippserd lippserd changed the title Mssql: implement row offset/limit support Mssql: Implement offset/limit support Jun 4, 2020
@lippserd lippserd deleted the feature/row-limit-offset-19 branch July 6, 2020 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lippserd lippserd Awaiting requested review from lippserd

Assignees

No one assigned

Labels

duplicate This issue or pull request already exists

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support pagination (LIMIT and OFFSET) for Microsoft SQL Server

2 participants

@Thomas-Gelf @lippserd