Reference symbols from global space via FQN #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lippserd
force-pushed
the
feature/reference-global-symbols-via-fqn
branch
2 times, most recently
from
d7467da
to
9b6989f
Compare
Motivation: PHP resolves relative function references at call time. For each function call PHP checks whether the function belongs to the current namespace or the global space. PHP7 introduces opcode optimizations which only apply for fully qualified name (FQN) calls.
Motivation: Since we use FQN calls for functions from the global space it makes sense to do that for classes too.
lippserd
force-pushed
the
feature/reference-global-symbols-via-fqn
branch
from
9b6989f
to
160c3b0
Compare
|
See https://veewee.github.io/blog/optimizing-php-performance-by-fq-function-calls/ and PHP-CS-Fixer/PHP-CS-Fixer#3048 for some details. |
|
Performance improve is insignificant. I'll close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP resolves relative function and constant references at call time. For each function call or access to a constant PHP checks whether the function or constant belongs to the current namespace or the global space. PHP7 introduces opcode optimizations which only apply for fully qualified name (FQN) calls.