New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings not applied correctly #13

Closed
MadeByMike opened this Issue Nov 6, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@MadeByMike

MadeByMike commented Nov 6, 2016

The following example should be a perfectly legitimate velocity value setting:

<a-entity position="0 0 0" particle-system="preset: snow; velocityValue:0 1 0"></a-entity>

However this doesn't work, if any 0 value is set, default settings will be applied. This because of the following code:

velocityValue: (this.data.velocityValue.x!==0&&this.data.velocityValue.y!==0&&this.data.velocityValue.z!==0?this.data.velocityValue:{x: 1, y: 8, z: 1}),

This is the same for all presets and properties with vec3 values.

I know it sucks to raise an issue and not a PR for something that has been identified like this. I'll raise a PR if I get time but noting it so I don't forget.

@weddingdj

This comment has been minimized.

Show comment
Hide comment
@weddingdj

weddingdj Nov 8, 2016

Contributor

Thanks for reporting!

Contributor

weddingdj commented Nov 8, 2016

Thanks for reporting!

@weddingdj weddingdj closed this in fac2bfd Jan 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment