Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please create a .net 4.7.1 dependency #70

Closed
ksmithRenweb opened this issue Oct 27, 2017 · 10 comments

Comments

Projects
None yet
4 participants
@ksmithRenweb
Copy link

commented Oct 27, 2017

What this entails is for 4.7.1 you would remove the System.ValueTuple nuget package. Allowing it to use the System.ValueTuple contained in 4.7.1.

This is a blocker for our project to go to 4.7.1, without this a runtime error occurs. Yours is the only library we are using with the issue. If need be I'll fork, and maintain it myself. But. It'd be nice if I didn't have to.

The runtime error is something like: "Method not found: ValueTuple(string,string) SomeMethod(variables)"
Which is caused because the System.ValueTuple version in .net 4.7.1 is a higher version than the nuget, so the 4.7.1 version is used. But your code is compiled against the nuget version that has a different signature. Thereby their signatures don't match and the run time error occurs.

Thanks!

@leastprivilege

This comment has been minimized.

Copy link
Contributor

commented Oct 28, 2017

I ran into similar problems before - my understanding is that targeting .net standard 2.0 should be all thats needed.

A similar problem is the reference to System.Net.Http - should the net452 reference the HttpClient from the old BCL - or the package?

Hope I can get some help @terrajobst or @davidfowl - project file.

@terrajobst

This comment has been minimized.

Copy link

commented Oct 28, 2017

Yes, it’s a known issue. We’ll publish an announcement next week.

@ksmithRenweb

This comment has been minimized.

Copy link
Author

commented Oct 30, 2017

@leastprivilege True, but that is only if you are in a position you can switch over to .net standard and .net core app. We have to wait for "other" stuff to become available in .net standard.

I spent 3 days trying to remove 4.7.1 before giving up an resetting computer. That this overrides other v4 frameworks was a bad thing. Might have been the time to put it in it's own versioned directory.

@leastprivilege

This comment has been minimized.

Copy link
Contributor

commented Oct 30, 2017

Well - as you can see from @terrajobst reply - this is a bug in .NET. Waiting for their official statement on how to fix/workaround.

@terrajobst

This comment has been minimized.

Copy link

commented Oct 31, 2017

@leastprivilege

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2017

@terrajobst thanks - now what workaround would you recommend for this library?

@leastprivilege

This comment has been minimized.

Copy link
Contributor

commented Nov 3, 2017

based on Microsoft's recommendation I added a net461 target

https://www.nuget.org/packages/IdentityModel/2.15.0-preview1

Can you give that a try and let me know if that fixes your problem?

@tstojecki

This comment has been minimized.

Copy link

commented Nov 8, 2017

Hi @leastprivilege
Are you suggesting that using IdentityModel (2.15.0) should resolve this issue?
We are running into The Method not found: System.ValueTuple issue in an aspnet core 2 project that targets net461 and references IdentityServer4.AccessTokenValidation package for AddIdentityServerAuthentication() in Startup.cs.

I have just installed IdentityModel (2.15.0). The dependencies look ok to me, including the dependent packages, but the error is still happening.

image

Any suggestions?

@leastprivilege

This comment has been minimized.

Copy link
Contributor

commented Nov 8, 2017

Good question - according to Microsoft this should be fine.

Can you please add a comment here:

dotnet/standard#567

@leastprivilege

This comment has been minimized.

Copy link
Contributor

commented Nov 18, 2017

Long story short: the .NET tooling is broken for the time being. Check the MS issue above for possible workarounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.