Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tests to pass after 2020 #581

Merged
merged 1 commit into from Feb 2, 2019

Conversation

bmwiedemann
Copy link
Contributor

@bmwiedemann bmwiedemann commented Jan 7, 2019

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes?
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

While working on reproducible builds for openSUSE, I found that
our python-pysaml2 package failed to build because of its tests after 2020.

This change helps to verify reproducible builds - making sure that software builds produce the same results anywhere anytime.
See https://reproducible-builds.org/ for why this matters.

Note: There are some remaining issues with SSL certs expiring in 2025.

This helps to verify reproducible builds.
See https://reproducible-builds.org/ for why this matters.
@codecov
Copy link

codecov bot commented Jan 7, 2019

Codecov Report

No coverage uploaded for pull request base (master@435ae01). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #581   +/-   ##
=========================================
  Coverage          ?   65.64%           
=========================================
  Files             ?      103           
  Lines             ?    25598           
  Branches          ?        0           
=========================================
  Hits              ?    16805           
  Misses            ?     8793           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 435ae01...32fc3c0. Read the comment docs.

@c00kiemon5ter
Copy link
Member

Hello and thanks for looking into this.

While what you propose resolves your issue, it is not a real fix, in the sense that it moves the problem to another time-span. What will happen (in the exceptional! case that these tests are still in use) in 2998?

We've already fixed a similar problem (and should fix those the same way) by mocking the actual time the system thinks it operates at. I will prepare a fix soon.

@bmwiedemann
Copy link
Contributor Author

I'm not at all worried about 2998 - neither of us will be around and probably not even this software.
And in the unlikely case, that someone is still running these tests then, they should be able to fix it.
We could even push the date to 9999 to give it more time than the pyramids in Egypt.

@c00kiemon5ter c00kiemon5ter merged commit 69711c3 into IdentityPython:master Feb 2, 2019
bmwiedemann added a commit to bmwiedemann/reproducibleopensuse that referenced this pull request Feb 6, 2019
to find y2k38 bugs without affecting every build
or to fix y2020 bugs without having to fix y2025 bugs at the same time
like IdentityPython/pysaml2#581
bmwiedemann added a commit to bmwiedemann/reproducibleopensuse that referenced this pull request Feb 8, 2019
to find y2k38 bugs without affecting every build
or to fix y2020 bugs without having to fix y2025 bugs at the same time
like IdentityPython/pysaml2#581
bmwiedemann added a commit to bmwiedemann/reproducibleopensuse that referenced this pull request Feb 27, 2019
to find y2k38 bugs without affecting every build
or to fix y2020 bugs without having to fix y2025 bugs at the same time
like IdentityPython/pysaml2#581
bmwiedemann added a commit to bmwiedemann/reproducibleopensuse that referenced this pull request Feb 27, 2019
to find y2k38 bugs without affecting every build
or to fix y2020 bugs without having to fix y2025 bugs at the same time
like IdentityPython/pysaml2#581
@bmwiedemann bmwiedemann deleted the test2020 branch March 24, 2019 19:27
@bmwiedemann bmwiedemann mentioned this pull request Apr 12, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants