New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow tests to pass after 2020 #581
Conversation
This helps to verify reproducible builds. See https://reproducible-builds.org/ for why this matters.
Codecov Report
@@ Coverage Diff @@
## master #581 +/- ##
=========================================
Coverage ? 65.64%
=========================================
Files ? 103
Lines ? 25598
Branches ? 0
=========================================
Hits ? 16805
Misses ? 8793
Partials ? 0Continue to review full report at Codecov.
|
|
Hello and thanks for looking into this. While what you propose resolves your issue, it is not a real fix, in the sense that it moves the problem to another time-span. What will happen (in the exceptional! case that these tests are still in use) in 2998? We've already fixed a similar problem (and should fix those the same way) by mocking the actual time the system thinks it operates at. I will prepare a fix soon. |
|
I'm not at all worried about 2998 - neither of us will be around and probably not even this software. |
to find y2k38 bugs without affecting every build or to fix y2020 bugs without having to fix y2025 bugs at the same time like IdentityPython/pysaml2#581
to find y2k38 bugs without affecting every build or to fix y2020 bugs without having to fix y2025 bugs at the same time like IdentityPython/pysaml2#581
to find y2k38 bugs without affecting every build or to fix y2020 bugs without having to fix y2025 bugs at the same time like IdentityPython/pysaml2#581
to find y2k38 bugs without affecting every build or to fix y2020 bugs without having to fix y2025 bugs at the same time like IdentityPython/pysaml2#581
While working on reproducible builds for openSUSE, I found that
our python-pysaml2 package failed to build because of its tests after 2020.
This change helps to verify reproducible builds - making sure that software builds produce the same results anywhere anytime.
See https://reproducible-builds.org/ for why this matters.
Note: There are some remaining issues with SSL certs expiring in 2025.