Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests pass after 2024 #606

Merged
merged 1 commit into from May 14, 2019
Merged

Conversation

bmwiedemann
Copy link
Contributor

@bmwiedemann bmwiedemann commented Apr 12, 2019

Background:
As part of my work on reproducible builds for openSUSE, I check that software still gives identical build results in the future.
The usual offset is +15 years, because that is how long I expect some software will be used in some places.
This showed up failing tests in our package build.

See https://reproducible-builds.org/ for why this matters.

I tested that this patch makes tests pass in 2037.

This is somewhat related to older PR #581

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes?
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

Background:
As part of my work on reproducible builds for openSUSE, I check that software still gives identical build results in the future.
The usual offset is +15 years, because that is how long I expect some software will be used in some places.
This showed up failing tests in our package build.

See https://reproducible-builds.org/ for why this matters.

This patch made tests pass in 2037
@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #606 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #606      +/-   ##
==========================================
- Coverage    65.6%   65.58%   -0.03%     
==========================================
  Files         103      103              
  Lines       25614    25614              
==========================================
- Hits        16805    16799       -6     
- Misses       8809     8815       +6
Impacted Files Coverage Δ
src/saml2/validate.py 73.33% <0%> (-2.75%) ⬇️
src/saml2/time_util.py 87.42% <0%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b397fc...7e75d95. Read the comment docs.

@bmwiedemann
Copy link
Contributor Author

For some reason, this makes 8 tests fail on i586.
one failure message is about 2999-12-13T10:05:05Z not being a valid XML dateTime.

@c00kiemon5ter
Copy link
Member

For some reason, this makes 8 tests fail on i586.
one failure message is about 2999-12-13T10:05:05Z not being a valid XML dateTime.

Is this python2? Can you check what import sys; print(sys.maxint) returns? I am guessing the system cannot represent the date as a number.

@c00kiemon5ter c00kiemon5ter merged commit 7ba4338 into IdentityPython:master May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants