How to add a custom implementation (e.g. WsFederation) of IReturnUrlParser if everything is internal set in AuthorizationRequest class in next v4.x ?

[alaincroisetiere]

Question

How to add a custom implementation (e.g. WsFederation) of IReturnUrlParser if everything is internal set in AuthorizationRequest class in next v4.x ?

Minimal working example

IdentityServer4.WsFederation/src/IdentityServer4.WsFederation/WsFederation/WsFederationReturnUrlParser.cs

        public async Task<AuthorizationRequest> ParseAsync(string returnUrl)
        {
            var user = _contextAccessor.HttpContext.User;

            var signInMessage = GetSignInRequestMessage(returnUrl);
            if (signInMessage == null) return null;

            // call validator
            var result = await _signinValidator.ValidateAsync(signInMessage, user);
            if (result.IsError) return null;

            // populate request
            var request = new AuthorizationRequest()
            {
                ClientId = result.Client.ClientId,
                IdP = result.SignInRequestMessage.HomeRealm,
                RedirectUri = result.SignInRequestMessage.Reply
            };

            foreach (var item in result.SignInRequestMessage.Parameters)
            {
                request.Parameters.Add(item.Key, item.Value);
            }

            return request;
        }

[brockallen]

So yea, looks like we changes them to internal? That was just an oversight. I can make the public again.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Questions are community supported only and the authors/maintainers may or may not have time to reply. If you or your company would like commercial support, please see here for more information.

[alaincroisetiere]

Bug planned into 4.0 milestone.

[brockallen]

Fixed. Thx for the heads up!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.