This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
Consistent expiration handling #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 5, 2017 14:15
Fixes IdentityServer#1084 Flip expression in DateTimeExtensions.HasExpired() to read like HasExceeded(). Check expiration and require consent for expired consent. Also remove consent from store. Remove expiration check from DefaultGrantStore that was returning null and causing callers to return invalid error statuses rather than expired. Also allows expired consents, refresh tokens, and reference tokens to be removed from the store. Change reference token expiration check to use DateTimeExtensions.HasExceeded(). Remove DefaultGrantStore expired grant "should not load" tests. Add test for expired consent. Update Expired_Reference_Token test.
|
@chrisowhite, It will cover your contributions to all .NET Foundation-managed open source projects. |
|
@chrisowhite, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
|
Thanks. We will look into it for v2. |
|
Thanks! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current time > expire time = expired grant.
#1084