Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Scope claim is always a string array #286

Merged
merged 1 commit into from Sep 12, 2016
Merged

Scope claim is always a string array #286

merged 1 commit into from Sep 12, 2016

Conversation

leastprivilege
Copy link
Member

No description provided.

@leastprivilege leastprivilege added this to the RC2 milestone Sep 12, 2016
@leastprivilege leastprivilege self-assigned this Sep 12, 2016
@dnfclas
Copy link

dnfclas commented Sep 12, 2016

Hi @leastprivilege, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@brockallen
Copy link
Member

:shipit: 👍

@brockallen brockallen merged commit 72f229d into dev Sep 12, 2016
@brockallen brockallen deleted the ScopesAsArray branch September 12, 2016 14:19
@adminnz
Copy link

adminnz commented Sep 15, 2016

There appears to be another issues.

When going through the tutorial in the documentation if you do the switching to hybrid flow (https://identityserver4.readthedocs.io/en/dev/quickstarts/5_hybrid_and_api_access.html) and have a user with multiple roles (e.g. "Admin" and "Developer").

They get combined into 1 claim (type = "role") with an array value of ["Admin", "Developer"]
Where previously when doing Implicit GrantType they would come across as two claims one with "Admin" and the other with "Developer" both claims having the type "role".

@brockallen
Copy link
Member

Ok, we can look into it. // @leastprivilege

@brockallen
Copy link
Member

@adminnz Looks like it's a Microsoft bug: aspnet/Security#976

@lock
Copy link

lock bot commented Jan 11, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants