From 13767a51fd778bba049621a733ac7fbe6221922b Mon Sep 17 00:00:00 2001 From: Jochen Eisinger Date: Fri, 12 Oct 2018 06:51:55 +0000 Subject: [PATCH] Remove the round-robin list for third-party additions Instead, require an email to opensource-licensing@ again until we figured out the new process. R=jam@chromium.org Change-Id: I352bd17e42cc1500994ba39368d25a0d91271f9c Reviewed-on: https://chromium-review.googlesource.com/c/1275846 Reviewed-by: John Abd-El-Malek Commit-Queue: Jochen Eisinger Cr-Commit-Position: refs/heads/master@{#599122} --- docs/adding_to_third_party.md | 9 ++++----- third_party/OWNERS | 4 ---- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/docs/adding_to_third_party.md b/docs/adding_to_third_party.md index 0d2e025b255e8..eda7e1838577c 100644 --- a/docs/adding_to_third_party.md +++ b/docs/adding_to_third_party.md @@ -127,12 +127,11 @@ can email one of the people in third_party/OWNERS for help. When adding a new package that could potentially carry security risk, make sure to highlight risk to security@chromium.org. You may be asked to add a README.security or, in dangerous cases, README.SECURITY.URGENTLY file. -* Add chromium-third-party@google.com as a reviewer on your change. This - will trigger an automatic round-robin assignment of the review to an - appropriate reviewer. This list does not receive or deliver email, so only - use it as a reviewer, not for other communication. +* Get licensing approval. Email opensource-licensing@google.com with relevant + details and a link to the CL. -Please send separate emails to the eng review and security lists. +Please send separate emails to the eng review, opensource licensing, and +security lists. Subsequent changes don't require third-party-owners approval; you can modify the code as much as you want. When you update code, be mindful of security-related diff --git a/third_party/OWNERS b/third_party/OWNERS index 6447bcb35e30d..7b36d33cafb40 100644 --- a/third_party/OWNERS +++ b/third_party/OWNERS @@ -14,10 +14,6 @@ # Eng reviewer file://ENG_REVIEW_OWNERS -# Automatic round-robin assignment of reviewer for third-party licenses. -# No one receives email to this list, just use it as a reviewer. -chromium-third-party@google.com - thakis@chromium.org per-file .gitignore=*