Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui::ws::Display::~Display are not deleted closing a window #112

Closed
tonikitoo opened this issue Jun 8, 2017 · 3 comments
Closed

ui::ws::Display::~Display are not deleted closing a window #112

tonikitoo opened this issue Jun 8, 2017 · 3 comments
Labels
duplicate

Comments

@tonikitoo
Copy link
Member

open one browser window.
then open another (control+n or menu)
close a window pressing "x".

ui::ws::Display::~Display is never called.
@tonikitoo
Copy link
Member Author

tonikitoo commented Jun 8, 2017 •
edited
Loading

we are currently only destroying ui::ws::Display instances upon exit:

#0 0x556221d6b817 base::debug::StackTrace::StackTrace()
#1 0x556224db43c0 ui::ws::Display::~Display()
#2 0x556224db46a9 ui::ws::Display::~Display()
#3 0x556224d93d51 ui::ws::DisplayManager::DestroyDisplay()
#4 0x556224d93680 ui::ws::DisplayManager::DestroyAllDisplays()
#5 0x556224da0405 ui::ws::WindowServer::~WindowServer()
#6 0x556224da0839 ui::ws::WindowServer::~WindowServer()
#7 0x55622193ea18 ui::Service::~Service()
#8 0x55622193eba9 ui::Service::~Service()
(..)

@msisov
Copy link
Member

msisov commented Jun 9, 2017 •
edited
Loading

Mostly a duplicate of #66

@tonikitoo tonikitoo mentioned this issue Jun 9, 2017
Closed
@tonikitoo
Copy link
Member Author

Ok, closing..

msisov pushed a commit to msisov/chromium that referenced this issue Sep 25, 2017
@tapted
[merge-m62] Use a lighter MD button stroke on Mac, but not on Retina,…
b296228 
… when not Harmony.

The button stroke is based on text color, which changes under Harmony.

Without full Harmony, the text is black and the button stroke looks
too dark on non-retina Mac screens. Compensate, and allow us to explore
whether we want special retina/non-retina logic for the button stroke
on Mac for full Harmony as well.

Bug: 762321
Change-Id: I7818478423a7aeb0706d107305605f6541d4a092
Reviewed-on: https://chromium-review.googlesource.com/651946
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499875}(cherry picked from commit 3d1dafe)
Reviewed-on: https://chromium-review.googlesource.com/658579
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{Igalia#112}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
msisov pushed a commit that referenced this issue Dec 23, 2018
@michaelpg
Add AllowWakeLocks policy to control system wake locks
25e62e2 
Adds a new policy, AllowWakeLocks, that can be used to disable wake
locks entirely.

The existing AllowScreenWakeLocks policy merely demotes screen wake
locks to system wake locks. If AllowWakeLocks is set to false, all wake
locks should be disabled.

Note that AllowScreenWakeLocks will now be ignored when AllowWakeLocks
is set to false.

Bug: 894645
Change-Id: I3d153801dcd9ed1f6fbf7339cdd4e7173552338c
Reviewed-on: https://chromium-review.googlesource.com/c/1278347
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Rahul Chaturvedi <rkc@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599220}(cherry picked from commit 1f44cfc)
Reviewed-on: https://chromium-review.googlesource.com/c/1287549
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#112}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
msisov pushed a commit that referenced this issue Jan 31, 2019
@pbos
Merge tab-loading-animation refactor to M72
2b2b4a5 
Prerequisite for other approved merges.

Bug: chromium:907642, chromium:908920

Refactor the tab-loading animation

This change instead updates the animation progress in delta-time
increments, which prevents a bunch of clock math and rewinding of start
timestamps.

Bug: None
Change-Id: I6848e3c3ca2d7c844f56f126d72c9b8420364b2a
Reviewed-on: https://chromium-review.googlesource.com/c/1356261
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613161}(cherry picked from commit 910efca)
Reviewed-on: https://chromium-review.googlesource.com/c/1365875
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#112}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
msisov pushed a commit that referenced this issue Mar 14, 2019
This is the cherry pick merge for the M73 branch which was approved h…
bdcdd26 
…ere: http://crbug.com/927215

[Autofill Assistant] Fix delayed prompt state issue.

Before this patch, the controller would stay in the running state
between the end of a script and the time runnable scripts were found.

In practice, for users, this meant that the website could be available,
but keyboard could be unavailable until a runnable script is found.
During that time the progress bar should have been pulsing but wasn't.

After this patch, the controller enters the prompt state immediately
after running a script, starting the pulsing and making the keyboard
available right away.

The cost of this is that in some corner case, the state can switch to
the prompt state then quickly enter an error case.

Bug: 122825639
Change-Id: Id4927a750370ec59e5c1216ebac01d54e377b2f3
Reviewed-on: https://chromium-review.googlesource.com/c/1442711
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#626996}(cherry picked from commit ba1715e)
Reviewed-on: https://chromium-review.googlesource.com/c/1449651
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3683@{#112}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tonikitoo @msisov