Initial Webdriver support #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdobersek
reviewed
Aug 12, 2021
zdobersek
reviewed
Aug 12, 2021
zdobersek
reviewed
Aug 12, 2021
cog.c
Outdated
| if (s_options.automation) { | ||
| uri = "about:blank"; |
There was a problem hiding this comment.
Could we just check whether CogShell object is automated? This would avoid the need for the option list entry.
There was a problem hiding this comment.
Checking the CogShell for automation is also possible. I've updated the patch with it.
Regarding the option list entry, I thought about it more like a way to document this flag, keeping consistent with other arguments (even though it has this special check before the application is created).
zdobersek
reviewed
Aug 12, 2021
This property will be used through cog to detect whether it has been launched in automated mode (e.g. launched from WebDriver). The most visible changes are the "automated" property and the new `cog_launcher_init_default(type)`, to initialize the default launcher with the given session type. The previous `cog_launcher_get_default` keeps the behavior of creating a non-automated launcher if none has been created yet (unlikely to happen, though).
Just a stub and defaulting to about:blank instead of requiring an URL explicitly. Actual automation pumbling to be done in following commits.
Mirror of the cog-launcher one.
Actual testing with both selenium and WPT should be limited by lack of multi view support as their fixtures rely on creating multiple views.
Usually from javascript's window.close or webkit_web_view_try_close. This is a very basic handler. We might want to expose it to the cog-shell API to allow the user to react to it.
aperezdc
reviewed
Aug 25, 2021
aperezdc
approved these changes
Aug 26, 2021
|
Thanks @lauromoura! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits add the basic plumbing needed to support running WebDriver scripts with Cog. For example, opening a page, following links and sending basic mouse and keyboard commands.
Still missing some documentation and examples of using it, alongside other bits like some visual feedback that the automation mode is enabled.
On the WebKit side, some harness patch will be needed to make the webdriver tests to run with
-DENABLE_COGenabled.