Add gamepad implementation. #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebased and implemented method to get the view backend |
ceyusa
force-pushed
the
gamepad
branch
2 times, most recently
from
d300be0
to
b07b8c7
Compare
|
sync'ed with latest review of libwpe |
ceyusa
force-pushed
the
gamepad
branch
4 times, most recently
from
b44cea4
to
9ef57fc
Compare
|
Downgraded libmanette version to 0.2.4 because is the one used in WebKit SDK, sadly the CI can install 0.2.3, which I cannot test locally easily. |
aperezdc
requested changes
May 2, 2022
There was a problem hiding this comment.
First things first, let me say that I think the overall structure of the code looks fine and worked fine for me here. Most of the comments are mostly style related, but please do read through them. I think we could merge an updated version of this PR once those have been addressed.
Thanks for the work on this, and please do let me know if anything is unclear! 🎮
ceyusa
force-pushed
the
gamepad
branch
3 times, most recently
from
06349b2
to
3b75e12
Compare
aperezdc
requested changes
May 4, 2022
ceyusa
force-pushed
the
gamepad
branch
3 times, most recently
from
8fbb397
to
d115341
Compare
|
Changes:
See demo in https://www.youtube.com/watch?v=iXh7GMR6pH8 |
ceyusa
force-pushed
the
gamepad
branch
4 times, most recently
from
ecb6044
to
bb85568
Compare
aperezdc
requested changes
Aug 11, 2022
aperezdc
requested changes
Aug 23, 2022
ceyusa
force-pushed
the
gamepad
branch
4 times, most recently
from
e2975e1
to
3501d99
Compare
The current implementation is based on libmanette. If libmanette is not available, a noop implementation is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation is based on libmanette. If libmanette is available a noop implementation is used.
Depends on WebPlatformForEmbedded/libwpe#88