core: Introduce a new CogView class #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aperezdc
requested review from
zdobersek,
alexgcastro,
carlosgcampos and
nikolaszimmermann
aperezdc
force-pushed
the
aperezdc/add-cogview
branch
2 times, most recently
from
c2e0f69
to
b66a0b3
Compare
zdobersek
approved these changes
May 17, 2023
Add a new CogView class, which extends WebKitWebView to avoid needing to specify the view backend for each instantiated view. Instead, the creation is delegated to the current CogPlatform, in one of the following two ways: - Overriding a new get_view_type vfunc, which returns the GType of a CogView subclass specific to the platform plug-in. The custom view class needs to implement a create_backend vfunc that creates the view backend to use. - Letting the core library use its fallback CogView subclass, which relies on the platform's get_view_backend vfunc. This matches the existing behaviour. This way platform plug-ins can opt-in to the new behaviour by implementing their own CogView subclass, and unchanged plug-ins will continue working during the transition.
aperezdc
force-pushed
the
aperezdc/add-cogview
branch
from
b66a0b3
to
46ea88a
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
CogViewclass, which extendsWebKitWebViewto avoid needing to specify the view backend for each instantiated view. Instead, the creation is delegated to the current CogPlatform, in one of the following two ways:Overriding a new
get_view_typevfunc, which returns theGTypeof aCogViewsubclass specific to the platform plug-in. The custom view class needs to implement acreate_backendvfunc that creates the view backend to use.Letting the core library use its fallback
CogViewsubclass, which relies on the platform'sget_view_backendvfunc. This matches the existing behaviour.This way platform plug-ins can opt-in to the new behaviour by implementing their own
CogViewsubclass, and unchanged plug-ins will continue working during the transition.