New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block task edition before a certain date #345

Closed
jaragunde opened this Issue Apr 3, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@jaragunde
Member

jaragunde commented Apr 3, 2017

We currently have the ability to block tasks older than a certain number of days, but sometimes is useful to have additional criteria to block tasks. In particular, it would be good to be able to set a date before which tasks would be blocked.

The result would be that two criteria to block tasks would be available, admins should be able to enable them independently, and in case both are enabled the most restrictive criterion would be applied.

jaragunde added a commit that referenced this issue Dec 5, 2017

[#345] Rename existing task block fields.
Existing task block configuration is named in a way it looks global,
e.g. the on/off switch is simply called "enabled". This patch renames
variables and DB columns in a more clear way, so we can add fields
for other kinds of task blocks.

jaragunde added a commit that referenced this issue Dec 5, 2017

[#345] Implement task block by date in backend.
Add columns in the database, the means to retrieve their values and
reimplement ConfigDAO::isWriteAllowedForDate taking into account two
values both the day number and the date limit.

jaragunde added a commit that referenced this issue Dec 5, 2017

[#345] Implement means to save the value of date block.
Modify all the layers, from the front-end to the DAO.

jaragunde added a commit that referenced this issue Dec 29, 2017

[#345] Implement means to save the value of date block.
Modify all the layers, from the front-end to the DAO.

jaragunde added a commit that referenced this issue Dec 29, 2017

[#345] Block task edition before a certain date
(Merge pull request #377 from Igalia/i345-lock-tasks-before-date)
@jaragunde

This comment has been minimized.

Show comment
Hide comment
@jaragunde

jaragunde Dec 29, 2017

Member
commit c6bc0181c54c76f2f582c8140cf5b86ee0e76ef4
Merge: f1b82d3 c9f795e
Author: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Date:   Fri Dec 29 12:16:18 2017 +0100

    [#345]  Block task edition before a certain date
    
    (Merge pull request #377 from Igalia/i345-lock-tasks-before-date)

commit c9f795e32301999ec9339480813c9c4b5dca3f97
Author: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Date:   Tue Dec 5 11:30:36 2017 +0100

    [#345] Implement means to save the value of date block.
    
    Modify all the layers, from the front-end to the DAO.

commit 8e661d547779e14ee820fb6ba3b37a002bfdfa31
Author: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Date:   Mon Dec 4 18:49:16 2017 +0100

    [#345] Implement task block by date in backend.
    
    Add columns in the database, the means to retrieve their values and
    reimplement ConfigDAO::isWriteAllowedForDate taking into account two
    values both the day number and the date limit.

commit 75a8ff6906f07d78a10a7b44da7738719635ab7a
Author: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Date:   Mon Dec 4 16:34:15 2017 +0100

    [#345] Rename existing task block fields.
    
    Existing task block configuration is named in a way it looks global,
    e.g. the on/off switch is simply called "enabled". This patch renames
    variables and DB columns in a more clear way, so we can add fields
    for other kinds of task blocks.

Member

jaragunde commented Dec 29, 2017

commit c6bc0181c54c76f2f582c8140cf5b86ee0e76ef4
Merge: f1b82d3 c9f795e
Author: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Date:   Fri Dec 29 12:16:18 2017 +0100

    [#345]  Block task edition before a certain date
    
    (Merge pull request #377 from Igalia/i345-lock-tasks-before-date)

commit c9f795e32301999ec9339480813c9c4b5dca3f97
Author: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Date:   Tue Dec 5 11:30:36 2017 +0100

    [#345] Implement means to save the value of date block.
    
    Modify all the layers, from the front-end to the DAO.

commit 8e661d547779e14ee820fb6ba3b37a002bfdfa31
Author: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Date:   Mon Dec 4 18:49:16 2017 +0100

    [#345] Implement task block by date in backend.
    
    Add columns in the database, the means to retrieve their values and
    reimplement ConfigDAO::isWriteAllowedForDate taking into account two
    values both the day number and the date limit.

commit 75a8ff6906f07d78a10a7b44da7738719635ab7a
Author: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Date:   Mon Dec 4 16:34:15 2017 +0100

    [#345] Rename existing task block fields.
    
    Existing task block configuration is named in a way it looks global,
    e.g. the on/off switch is simply called "enabled". This patch renames
    variables and DB columns in a more clear way, so we can add fields
    for other kinds of task blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment