Permalink
Browse files

[css-grid] Rename gutter properties to remove "grid-" prefix

https://bugs.webkit.org/show_bug.cgi?id=180290

Reviewed by Javier Fernandez.

LayoutTests/imported/w3c:

Imported WPT tests from css/css-align/gaps/.
And also update the tests on css/css-grid/alignment/ gutter tests.

* web-platform-tests/css/css-align/gaps/column-gap-animation-001-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/column-gap-animation-001.html: Added.
* web-platform-tests/css/css-align/gaps/column-gap-animation-002-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/column-gap-animation-002.html: Added.
* web-platform-tests/css/css-align/gaps/column-gap-animation-003-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/column-gap-animation-003.html: Added.
* web-platform-tests/css/css-align/gaps/column-gap-parsing-001-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/column-gap-parsing-001.html: Added.
* web-platform-tests/css/css-align/gaps/gap-animation-001-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/gap-animation-001.html: Added.
* web-platform-tests/css/css-align/gaps/gap-animation-002-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/gap-animation-002.html: Added.
* web-platform-tests/css/css-align/gaps/gap-animation-003-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/gap-animation-003.html: Added.
* web-platform-tests/css/css-align/gaps/gap-animation-004-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/gap-animation-004.html: Added.
* web-platform-tests/css/css-align/gaps/gap-parsing-001-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/gap-parsing-001.html: Added.
* web-platform-tests/css/css-align/gaps/grid-column-gap-parsing-001-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/grid-column-gap-parsing-001.html: Added.
* web-platform-tests/css/css-align/gaps/grid-gap-parsing-001-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/grid-gap-parsing-001.html: Added.
* web-platform-tests/css/css-align/gaps/grid-row-gap-parsing-001-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/grid-row-gap-parsing-001.html: Added.
* web-platform-tests/css/css-align/gaps/row-gap-animation-001-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/row-gap-animation-001.html: Added.
* web-platform-tests/css/css-align/gaps/row-gap-animation-002-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/row-gap-animation-002.html: Added.
* web-platform-tests/css/css-align/gaps/row-gap-animation-003-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/row-gap-animation-003.html: Added.
* web-platform-tests/css/css-align/gaps/row-gap-parsing-001-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/row-gap-parsing-001.html: Added.
* web-platform-tests/css/css-align/gaps/w3c-import.log: Added.
* web-platform-tests/css/css-grid/alignment/grid-gutters-001-expected.html:
* web-platform-tests/css/css-grid/alignment/grid-gutters-002-expected.html:
* web-platform-tests/css/css-grid/alignment/grid-gutters-003-expected.html:
* web-platform-tests/css/css-grid/alignment/grid-gutters-004-expected.html:
* web-platform-tests/css/css-grid/alignment/grid-gutters-005-expected.html:
* web-platform-tests/css/css-grid/alignment/grid-gutters-006-expected.html:
* web-platform-tests/css/css-grid/alignment/grid-gutters-007-expected.html:
* web-platform-tests/css/css-grid/alignment/grid-gutters-008-expected.html:
* web-platform-tests/css/css-grid/alignment/grid-gutters-009-expected.html:
* web-platform-tests/css/css-grid/alignment/grid-gutters-010-expected.html:

Source/WebCore:

This patch applies the resoultion of the CSS WG to unprefix
the CSS Grid Layout gutter properties:
w3c/csswg-drafts#1696

column-gap already existed before, as it's part of Multicol.
The patch adds the new properties row-gap and gap, and keep the legacy ones
as aliases:
- grid-column-gap => column-gap
- grid-row-gap => row-gap
- grid-gap => gap

As column-gap was already animatable, this change takes advantage
to make animatable row-gap too.

Tests: imported/w3c/web-platform-tests/css/css-align/gaps/

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
* css/CSSProperties.json:
* css/StyleProperties.cpp:
* css/parser/CSSParserFastPaths.cpp:
(WebCore::isSimpleLengthPropertyID):
* css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::CSSPropertyParser::parseShorthand):
* page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::availableSpaceForGutters const):
(WebCore::RenderGrid::gridGap const):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::gridAutoRows const):
(WebCore::RenderStyle::columnGap const):
(WebCore::RenderStyle::rowGap const):
(WebCore::RenderStyle::setGridItemRowEnd):
(WebCore::RenderStyle::setColumnGap):
(WebCore::RenderStyle::setRowGap):
(WebCore::RenderStyle::initialRowGap):
* rendering/style/StyleGridData.cpp:
(WebCore::StyleGridData::StyleGridData):
* rendering/style/StyleGridData.h:
(WebCore::StyleGridData::operator== const):
* rendering/style/StyleMultiColData.cpp:
(WebCore::StyleMultiColData::StyleMultiColData):
(WebCore::StyleMultiColData::operator== const):
* rendering/style/StyleMultiColData.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator== const):
* rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

* TestExpectations: We're now passing some gutters tests,
so removing them from TestExpectations.
* fast/css-grid-layout/grid-gutters-get-set.html: Removed. This is now covered by WPT tests.
* fast/css-grid-layout/grid-shorthand-get-set-expected.txt: Update results for gutter properties
as default value is now "normal".
* fast/css-grid-layout/grid-shorthand-get-set.html: Update checks for gutter properties
as default value is now "normal".


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@228095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information...
rego@igalia.com
rego@igalia.com committed Feb 5, 2018
1 parent 45306b5 commit f6a01a65403ec599f57ec0c5408db29840de423d
Showing with 1,786 additions and 203 deletions.
  1. +15 −0 LayoutTests/ChangeLog
  2. +0 −10 LayoutTests/TestExpectations
  3. +0 −108 LayoutTests/fast/css-grid-layout/grid-gutters-get-set.html
  4. +4 −4 LayoutTests/fast/css-grid-layout/grid-shorthand-get-set-expected.txt
  5. +4 −4 LayoutTests/fast/css-grid-layout/grid-shorthand-get-set.html
  6. +54 −0 LayoutTests/imported/w3c/ChangeLog
  7. +3 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/column-gap-animation-001-expected.txt
  8. +36 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/column-gap-animation-001.html
  9. +3 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/column-gap-animation-002-expected.txt
  10. +34 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/column-gap-animation-002.html
  11. +3 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/column-gap-animation-003-expected.txt
  12. +33 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/column-gap-animation-003.html
  13. +19 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/column-gap-parsing-001-expected.txt
  14. +144 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/column-gap-parsing-001.html
  15. +3 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/gap-animation-001-expected.txt
  16. +38 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/gap-animation-001.html
  17. +3 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/gap-animation-002-expected.txt
  18. +36 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/gap-animation-002.html
  19. +3 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/gap-animation-003-expected.txt
  20. +35 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/gap-animation-003.html
  21. +3 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/gap-animation-004-expected.txt
  22. +37 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/gap-animation-004.html
  23. +27 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/gap-parsing-001-expected.txt
  24. +226 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/gap-parsing-001.html
  25. +19 −0 ...Tests/imported/w3c/web-platform-tests/css/css-align/gaps/grid-column-gap-parsing-001-expected.txt
  26. +144 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/grid-column-gap-parsing-001.html
  27. +27 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/grid-gap-parsing-001-expected.txt
  28. +226 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/grid-gap-parsing-001.html
  29. +19 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/grid-row-gap-parsing-001-expected.txt
  30. +144 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/grid-row-gap-parsing-001.html
  31. +3 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/row-gap-animation-001-expected.txt
  32. +36 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/row-gap-animation-001.html
  33. +3 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/row-gap-animation-002-expected.txt
  34. +34 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/row-gap-animation-002.html
  35. +3 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/row-gap-animation-003-expected.txt
  36. +33 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/row-gap-animation-003.html
  37. +19 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/row-gap-parsing-001-expected.txt
  38. +144 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/row-gap-parsing-001.html
  39. +32 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/w3c-import.log
  40. +1 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-001-expected.html
  41. +1 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-002-expected.html
  42. +1 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-003-expected.html
  43. +1 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-004-expected.html
  44. +1 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-005-expected.html
  45. +1 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-006-expected.html
  46. +1 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-007-expected.html
  47. +1 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-008-expected.html
  48. +1 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-009-expected.html
  49. +1 −0 LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-010-expected.html
  50. +58 −0 Source/WebCore/ChangeLog
  51. +7 −8 Source/WebCore/css/CSSComputedStyleDeclaration.cpp
  52. +30 −34 Source/WebCore/css/CSSProperties.json
  53. +1 −0 Source/WebCore/css/StyleProperties.cpp
  54. +0 −2 Source/WebCore/css/parser/CSSParserFastPaths.cpp
  55. +7 −8 Source/WebCore/css/parser/CSSPropertyParser.cpp
  56. +1 −0 Source/WebCore/page/animation/CSSPropertyAnimation.cpp
  57. +7 −4 Source/WebCore/rendering/RenderGrid.cpp
  58. +5 −9 Source/WebCore/rendering/style/RenderStyle.h
  59. +0 −4 Source/WebCore/rendering/style/StyleGridData.cpp
  60. +0 −4 Source/WebCore/rendering/style/StyleGridData.h
  61. +1 −2 Source/WebCore/rendering/style/StyleMultiColData.cpp
  62. +0 −1 Source/WebCore/rendering/style/StyleMultiColData.h
  63. +7 −1 Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp
  64. +3 −0 Source/WebCore/rendering/style/StyleRareNonInheritedData.h
View
@@ -1,3 +1,18 @@
2018-02-05 Manuel Rego Casasnovas <rego@igalia.com>
[css-grid] Rename gutter properties to remove "grid-" prefix
https://bugs.webkit.org/show_bug.cgi?id=180290
Reviewed by Javier Fernandez.
* TestExpectations: We're now passing some gutters tests,
so removing them from TestExpectations.
* fast/css-grid-layout/grid-gutters-get-set.html: Removed. This is now covered by WPT tests.
* fast/css-grid-layout/grid-shorthand-get-set-expected.txt: Update results for gutter properties
as default value is now "normal".
* fast/css-grid-layout/grid-shorthand-get-set.html: Update checks for gutter properties
as default value is now "normal".
2018-02-05 Ms2ger <Ms2ger@igalia.com>
Implement createImageBitmap(HTMLVideoElement)
@@ -492,16 +492,6 @@ webkit.org/b/136754 css3/flexbox/csswg/ttwf-reftest-flex-wrap.html [ ImageOnlyFa
webkit.org/b/165062 fast/css-grid-layout/grid-baseline.html [ ImageOnlyFailure ]
webkit.org/b/165062 fast/css-grid-layout/grid-baseline-margins.html [ ImageOnlyFailure ]
webkit.org/b/169271 imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-sizing-alignment-001.html [ ImageOnlyFailure ]
webkit.org/b/180290 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-001.html [ ImageOnlyFailure ]
webkit.org/b/180290 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-002.html [ ImageOnlyFailure ]
webkit.org/b/180290 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-003.html [ ImageOnlyFailure ]
webkit.org/b/180290 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-004.html [ ImageOnlyFailure ]
webkit.org/b/180290 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-005.html [ ImageOnlyFailure ]
webkit.org/b/180290 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-006.html [ ImageOnlyFailure ]
webkit.org/b/180290 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-007.html [ ImageOnlyFailure ]
webkit.org/b/180290 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-008.html [ ImageOnlyFailure ]
webkit.org/b/180290 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-009.html [ ImageOnlyFailure ]
webkit.org/b/180290 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-010.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-grid/abspos/absolute-positioning-changing-containing-block-001.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-grid/abspos/grid-item-absolute-positioning-dynamic-001.html [ ImageOnlyFailure ]

This file was deleted.

Oops, something went wrong.
@@ -332,10 +332,10 @@ PASS getComputedStyle(element, '').getPropertyValue('grid-auto-rows') is "auto"
PASS element.style.gridAutoRows is "initial"
Test the inherit value does not affect gutter properties (grid-*-gap)
PASS getComputedStyle(anotherElement, '').getPropertyValue('grid-column-gap') is "0px"
PASS getComputedStyle(anotherElement, '').getPropertyValue('grid-row-gap') is "0px"
PASS getComputedStyle(anotherElement, '').getPropertyValue('grid-column-gap') is "0px"
PASS getComputedStyle(anotherElement, '').getPropertyValue('grid-row-gap') is "0px"
PASS getComputedStyle(anotherElement, '').getPropertyValue('grid-column-gap') is "normal"
PASS getComputedStyle(anotherElement, '').getPropertyValue('grid-row-gap') is "normal"
PASS getComputedStyle(anotherElement, '').getPropertyValue('grid-column-gap') is "normal"
PASS getComputedStyle(anotherElement, '').getPropertyValue('grid-row-gap') is "normal"
PASS successfullyParsed is true
TEST COMPLETE
@@ -210,11 +210,11 @@
document.body.style.gridColumnGap = "20px";
var anotherElement = document.createElement("div");
document.body.appendChild(anotherElement);
shouldBeEqualToString("getComputedStyle(anotherElement, '').getPropertyValue('grid-column-gap')", "0px");
shouldBeEqualToString("getComputedStyle(anotherElement, '').getPropertyValue('grid-row-gap')", "0px");
shouldBeEqualToString("getComputedStyle(anotherElement, '').getPropertyValue('grid-column-gap')", "normal");
shouldBeEqualToString("getComputedStyle(anotherElement, '').getPropertyValue('grid-row-gap')", "normal");
anotherElement.style.grid = "inherit";
shouldBeEqualToString("getComputedStyle(anotherElement, '').getPropertyValue('grid-column-gap')", "0px");
shouldBeEqualToString("getComputedStyle(anotherElement, '').getPropertyValue('grid-row-gap')", "0px");
shouldBeEqualToString("getComputedStyle(anotherElement, '').getPropertyValue('grid-column-gap')", "normal");
shouldBeEqualToString("getComputedStyle(anotherElement, '').getPropertyValue('grid-row-gap')", "normal");
</script>
</body>
</html>
@@ -1,3 +1,57 @@
2018-02-05 Manuel Rego Casasnovas <rego@igalia.com>
[css-grid] Rename gutter properties to remove "grid-" prefix
https://bugs.webkit.org/show_bug.cgi?id=180290
Reviewed by Javier Fernandez.
Imported WPT tests from css/css-align/gaps/.
And also update the tests on css/css-grid/alignment/ gutter tests.
* web-platform-tests/css/css-align/gaps/column-gap-animation-001-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/column-gap-animation-001.html: Added.
* web-platform-tests/css/css-align/gaps/column-gap-animation-002-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/column-gap-animation-002.html: Added.
* web-platform-tests/css/css-align/gaps/column-gap-animation-003-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/column-gap-animation-003.html: Added.
* web-platform-tests/css/css-align/gaps/column-gap-parsing-001-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/column-gap-parsing-001.html: Added.
* web-platform-tests/css/css-align/gaps/gap-animation-001-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/gap-animation-001.html: Added.
* web-platform-tests/css/css-align/gaps/gap-animation-002-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/gap-animation-002.html: Added.
* web-platform-tests/css/css-align/gaps/gap-animation-003-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/gap-animation-003.html: Added.
* web-platform-tests/css/css-align/gaps/gap-animation-004-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/gap-animation-004.html: Added.
* web-platform-tests/css/css-align/gaps/gap-parsing-001-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/gap-parsing-001.html: Added.
* web-platform-tests/css/css-align/gaps/grid-column-gap-parsing-001-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/grid-column-gap-parsing-001.html: Added.
* web-platform-tests/css/css-align/gaps/grid-gap-parsing-001-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/grid-gap-parsing-001.html: Added.
* web-platform-tests/css/css-align/gaps/grid-row-gap-parsing-001-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/grid-row-gap-parsing-001.html: Added.
* web-platform-tests/css/css-align/gaps/row-gap-animation-001-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/row-gap-animation-001.html: Added.
* web-platform-tests/css/css-align/gaps/row-gap-animation-002-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/row-gap-animation-002.html: Added.
* web-platform-tests/css/css-align/gaps/row-gap-animation-003-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/row-gap-animation-003.html: Added.
* web-platform-tests/css/css-align/gaps/row-gap-parsing-001-expected.txt: Added.
* web-platform-tests/css/css-align/gaps/row-gap-parsing-001.html: Added.
* web-platform-tests/css/css-align/gaps/w3c-import.log: Added.
* web-platform-tests/css/css-grid/alignment/grid-gutters-001-expected.html:
* web-platform-tests/css/css-grid/alignment/grid-gutters-002-expected.html:
* web-platform-tests/css/css-grid/alignment/grid-gutters-003-expected.html:
* web-platform-tests/css/css-grid/alignment/grid-gutters-004-expected.html:
* web-platform-tests/css/css-grid/alignment/grid-gutters-005-expected.html:
* web-platform-tests/css/css-grid/alignment/grid-gutters-006-expected.html:
* web-platform-tests/css/css-grid/alignment/grid-gutters-007-expected.html:
* web-platform-tests/css/css-grid/alignment/grid-gutters-008-expected.html:
* web-platform-tests/css/css-grid/alignment/grid-gutters-009-expected.html:
* web-platform-tests/css/css-grid/alignment/grid-gutters-010-expected.html:
2018-02-05 Ms2ger <Ms2ger@igalia.com>
Implement createImageBitmap(HTMLVideoElement)
@@ -0,0 +1,3 @@
PASS column-gap is interpolable
@@ -0,0 +1,36 @@
<!DOCTYPE html>
<meta charset="utf-8">
<title>CSS Box Alignment Test: column-gap test animation</title>
<link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
<link rel="help" href="https://www.w3.org/TR/css-align-3/#column-row-gap">
<link rel="help" href="https://www.w3.org/TR/css-animations-1/#keyframes">
<meta name="assert" content="This test checks that column-gap property is interpolable.">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<style>
@keyframes column-gap-0-to-100 {
from { column-gap: 0px; }
to { column-gap: 100px; }
}
#target {
animation-name: column-gap-0-to-100;
animation-timing-function: linear;
animation-duration: 2s;
animation-delay: -1s;
animation-play-state: paused;
}
</style>
<body>
<div id="target"></div>
<div id="log"></div>
<script>
test(
function(){
var target = document.getElementById("target");
assert_equals(getComputedStyle(target).columnGap, "50px");
}, "column-gap is interpolable");
</script>
</body>
@@ -0,0 +1,3 @@
PASS column-gap: normal is not interpolable
@@ -0,0 +1,34 @@
<!DOCTYPE html>
<meta charset="utf-8">
<title>CSS Box Alignment Test: column-gap normal test animation</title>
<link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
<link rel="help" href="https://www.w3.org/TR/css-align-3/#column-row-gap">
<link rel="help" href="https://www.w3.org/TR/css-animations-1/#keyframes">
<meta name="assert" content="This test checks that 'normal' value for column-gap property is not interpolable.">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<style>
@keyframes column-gap-normal-to-100 {
from { column-gap: normal; }
to { column-gap: 100px; }
}
#target {
animation-name: column-gap-normal-to-100;
animation-duration: 2s;
animation-delay: -1s;
animation-play-state: paused;
}
</style>
<body>
<div id="target"></div>
<div id="log"></div>
<script>
test(
function(){
var target = document.getElementById("target");
assert_equals(getComputedStyle(target).columnGap, "100px");
}, "column-gap: normal is not interpolable");
</script>
</body>
@@ -0,0 +1,3 @@
PASS Default column-gap is not interpolable
@@ -0,0 +1,33 @@
<!DOCTYPE html>
<meta charset="utf-8">
<title>CSS Box Alignment Test: Default column-gap test animation</title>
<link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
<link rel="help" href="https://www.w3.org/TR/css-align-3/#column-row-gap">
<link rel="help" href="https://www.w3.org/TR/css-animations-1/#keyframes">
<meta name="assert" content="This test checks that the default value for column-gap property, which is 'normal', is not interpolable.">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<style>
@keyframes column-gap-to-100 {
to { column-gap: 100px; }
}
#target {
animation-name: column-gap-to-100;
animation-duration: 2s;
animation-delay: -1s;
animation-play-state: paused;
}
</style>
<body>
<div id="target"></div>
<div id="log"></div>
<script>
test(
function(){
var target = document.getElementById("target");
assert_equals(getComputedStyle(target).columnGap, "100px");
}, "Default column-gap is not interpolable");
</script>
</body>
@@ -0,0 +1,19 @@
PASS Default column-gap is 'normal'
PASS column-gap accepts pixels
PASS column-gap accepts em
PASS column-gap accepts vw
PASS column-gap accepts percentage
PASS column-gap accepts calc()
PASS Initial column-gap is 'normal'
PASS Initial column-gap is 'normal' 2
PASS Initial inherited column-gap is 'normal'
PASS column-gap is inheritable
PASS Negative column-gap is invalid
PASS 'max-content' column-gap is invalid
PASS 'none' column-gap is invalid
PASS column-gap with multiple values is invalid
PASS Angle column-gap is invalid
PASS Resolution column-gap is invalid
PASS Time column-gap is invalid
Oops, something went wrong.

0 comments on commit f6a01a6

Please sign in to comment.