From 7a88282437bbc2b8f78f81264c33e5e85b943689 Mon Sep 17 00:00:00 2001 From: dobromirts Date: Mon, 24 Feb 2025 12:08:27 +0200 Subject: [PATCH 1/3] chore(*): add missing extras directive imports --- .../data-analysis-dock-manager.component.ts | 5 +++-- .../grid-dynamic-chart-data.component.ts | 4 ++-- projects/app-lob/src/app/services/floating-panes.service.ts | 4 +++- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/projects/app-lob/src/app/grid-dynamic-chart-data/data-analysis-dock-manager/data-analysis-dock-manager.component.ts b/projects/app-lob/src/app/grid-dynamic-chart-data/data-analysis-dock-manager/data-analysis-dock-manager.component.ts index 3ff1e208d6..cbe28f9d6a 100644 --- a/projects/app-lob/src/app/grid-dynamic-chart-data/data-analysis-dock-manager/data-analysis-dock-manager.component.ts +++ b/projects/app-lob/src/app/grid-dynamic-chart-data/data-analysis-dock-manager/data-analysis-dock-manager.component.ts @@ -1,6 +1,6 @@ /* eslint-disable max-len */ import { AfterViewInit, ChangeDetectorRef, Component, CUSTOM_ELEMENTS_SCHEMA, ElementRef, OnInit, Pipe, PipeTransform, QueryList, ViewChild, ViewChildren } from '@angular/core'; -import { IgxChartIntegrationDirective, OPTIONS_TYPE, CHART_TYPE } from 'igniteui-angular-extras'; +import { IgxChartIntegrationDirective, IgxContextMenuDirective, OPTIONS_TYPE, CHART_TYPE } from 'igniteui-angular-extras'; import { IgcDockManagerLayout, IgcDockManagerPaneType, IgcSplitPane, IgcSplitPaneOrientation } from 'igniteui-dockmanager'; import { FinancialData } from '../../data/financialData'; import { FloatingPanesService } from '../../services/floating-panes.service'; @@ -53,7 +53,7 @@ export class HastDuplicateLayouts implements PipeTransform { templateUrl: './data-analysis-dock-manager.component.html', styleUrls: ['./data-analysis-dock-manager.component.scss'], providers: [FloatingPanesService], - imports: [IgxGridComponent, IgxChartIntegrationDirective, IgxBadgeComponent, IgxColumnComponent, IgxCellTemplateDirective, NgFor, NgIf, NgClass, IgxDividerDirective, DockSlotComponent, DecimalPipe, TitleCasePipe, CurrencyPipe, FilterTypePipe, HastDuplicateLayouts], + imports: [IgxGridComponent, IgxChartIntegrationDirective, IgxContextMenuDirective, IgxBadgeComponent, IgxColumnComponent, IgxCellTemplateDirective, NgClass, IgxDividerDirective, DockSlotComponent, DecimalPipe, TitleCasePipe, CurrencyPipe, FilterTypePipe, HastDuplicateLayouts], schemas: [CUSTOM_ELEMENTS_SCHEMA] }) export class DataAnalysisDockManagerComponent implements OnInit, AfterViewInit { @@ -82,6 +82,7 @@ export class DataAnalysisDockManagerComponent implements OnInit, AfterViewInit { public ngAfterViewInit() { this.allCharts = this.chartIntegration.getAvailableCharts(); + this.cdr.detectChanges(); const pieChartOptions = { labelsPosition: 4, allowSliceExplosion: true, diff --git a/projects/app-lob/src/app/grid-dynamic-chart-data/grid-dynamic-chart-data.component.ts b/projects/app-lob/src/app/grid-dynamic-chart-data/grid-dynamic-chart-data.component.ts index 32c75dda7b..5ebb2325b5 100644 --- a/projects/app-lob/src/app/grid-dynamic-chart-data/grid-dynamic-chart-data.component.ts +++ b/projects/app-lob/src/app/grid-dynamic-chart-data/grid-dynamic-chart-data.component.ts @@ -1,6 +1,6 @@ /* eslint-disable max-len */ import { AfterViewInit, Component, OnInit, ViewChild } from '@angular/core'; -import { IgxChartIntegrationDirective, OPTIONS_TYPE, CHART_TYPE, PageHeaderComponent } from 'igniteui-angular-extras'; +import { IgxChartIntegrationDirective, IgxContextMenuDirective, OPTIONS_TYPE, CHART_TYPE, PageHeaderComponent } from 'igniteui-angular-extras'; import { FinancialData } from '../data/financialData'; import { IgxGridComponent, IgxColumnComponent, IgxCellTemplateDirective } from 'igniteui-angular'; @@ -10,7 +10,7 @@ import { DecimalPipe, CurrencyPipe } from '@angular/common'; selector: 'app-grid-dynamic-chart-data', templateUrl: './grid-dynamic-chart-data.component.html', styleUrls: ['./grid-dynamic-chart-data.component.scss'], - imports: [IgxGridComponent, PageHeaderComponent, IgxChartIntegrationDirective, IgxColumnComponent, IgxCellTemplateDirective, DecimalPipe, CurrencyPipe] + imports: [IgxGridComponent, PageHeaderComponent, IgxChartIntegrationDirective, IgxContextMenuDirective, IgxColumnComponent, IgxCellTemplateDirective, DecimalPipe, CurrencyPipe] }) export class GridDynamicChartDataComponent implements OnInit, AfterViewInit { diff --git a/projects/app-lob/src/app/services/floating-panes.service.ts b/projects/app-lob/src/app/services/floating-panes.service.ts index 37e6eba464..10afdd70c0 100644 --- a/projects/app-lob/src/app/services/floating-panes.service.ts +++ b/projects/app-lob/src/app/services/floating-panes.service.ts @@ -24,7 +24,9 @@ export class FloatingPanesService { if (this.floatingPanes.length) { const lastPane = this.floatingPanes[this.floatingPanes.length - 1]; - pane.floatingLocation = {x: lastPane.floatingLocation.x + 10, y: lastPane.floatingLocation.y + 10} ; + if (lastPane.floatingLocation) { + pane.floatingLocation = {x: lastPane.floatingLocation.x + 10, y: lastPane.floatingLocation.y + 10}; + } } else { pane.floatingLocation = this.initialPanePosition; } From 938838b123653543dbf47b06312b391d24e42465 Mon Sep 17 00:00:00 2001 From: dobromirts Date: Mon, 24 Feb 2025 14:50:13 +0200 Subject: [PATCH 2/3] chore(*): update extras version --- package-lock.json | 8 ++++---- package.json | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package-lock.json b/package-lock.json index cf428da663..41cb7c2392 100644 --- a/package-lock.json +++ b/package-lock.json @@ -34,7 +34,7 @@ "igniteui-angular": "^19.0.0", "igniteui-angular-charts": "^19.0.0", "igniteui-angular-core": "^19.0.0", - "igniteui-angular-extras": "^19.0.1", + "igniteui-angular-extras": "^19.0.3", "igniteui-angular-i18n": "^19.0.0", "igniteui-dockmanager": "^1.14.2", "igniteui-live-editing": "^3.0.0", @@ -13017,9 +13017,9 @@ } }, "node_modules/igniteui-angular-extras": { - "version": "19.0.1", - "resolved": "https://registry.npmjs.org/igniteui-angular-extras/-/igniteui-angular-extras-19.0.1.tgz", - "integrity": "sha512-+uSDeJG0h2vfJ61WhLGT6fwxBmmyH9rfuP8nq6Zvzco0gg+ZHQ2oZoKQcC4ZBSp28ZzJCWOY3VmmZ7xcjSQBLw==", + "version": "19.0.3", + "resolved": "https://registry.npmjs.org/igniteui-angular-extras/-/igniteui-angular-extras-19.0.3.tgz", + "integrity": "sha512-sG3uTLLV/KZk5aOexdKtevcmp5wUd/FGEN60CXX2IQRzWdABIC/khzNrAYpP6tnyi8QsYR+gjrXQb+kr3RJUMQ==", "dependencies": { "igniteui-trial-watermark": "^3.0.2", "tslib": "^2.0.0" diff --git a/package.json b/package.json index 373bf1eba1..f645c2ab7f 100644 --- a/package.json +++ b/package.json @@ -68,7 +68,7 @@ "igniteui-angular": "^19.0.0", "igniteui-angular-charts": "^19.0.0", "igniteui-angular-core": "^19.0.0", - "igniteui-angular-extras": "^19.0.1", + "igniteui-angular-extras": "^19.0.3", "igniteui-angular-i18n": "^19.0.0", "igniteui-dockmanager": "^1.14.2", "igniteui-live-editing": "^3.0.0", From 7b89bad2660e96fd249796c37932713498821a66 Mon Sep 17 00:00:00 2001 From: dobromirts Date: Mon, 24 Feb 2025 16:12:08 +0200 Subject: [PATCH 3/3] chore(*): restore data analytics ng imports --- .../data-analysis-dock-manager.component.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/app-lob/src/app/grid-dynamic-chart-data/data-analysis-dock-manager/data-analysis-dock-manager.component.ts b/projects/app-lob/src/app/grid-dynamic-chart-data/data-analysis-dock-manager/data-analysis-dock-manager.component.ts index cbe28f9d6a..296c86f685 100644 --- a/projects/app-lob/src/app/grid-dynamic-chart-data/data-analysis-dock-manager/data-analysis-dock-manager.component.ts +++ b/projects/app-lob/src/app/grid-dynamic-chart-data/data-analysis-dock-manager/data-analysis-dock-manager.component.ts @@ -53,7 +53,7 @@ export class HastDuplicateLayouts implements PipeTransform { templateUrl: './data-analysis-dock-manager.component.html', styleUrls: ['./data-analysis-dock-manager.component.scss'], providers: [FloatingPanesService], - imports: [IgxGridComponent, IgxChartIntegrationDirective, IgxContextMenuDirective, IgxBadgeComponent, IgxColumnComponent, IgxCellTemplateDirective, NgClass, IgxDividerDirective, DockSlotComponent, DecimalPipe, TitleCasePipe, CurrencyPipe, FilterTypePipe, HastDuplicateLayouts], + imports: [IgxGridComponent, IgxChartIntegrationDirective, IgxContextMenuDirective, IgxBadgeComponent, IgxColumnComponent, IgxCellTemplateDirective, NgFor, NgIf, NgClass, IgxDividerDirective, DockSlotComponent, DecimalPipe, TitleCasePipe, CurrencyPipe, FilterTypePipe, HastDuplicateLayouts], schemas: [CUSTOM_ELEMENTS_SCHEMA] }) export class DataAnalysisDockManagerComponent implements OnInit, AfterViewInit {