Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esf): added role=menu to esf article - master #10515

Merged
merged 6 commits into from Nov 22, 2021

Conversation

igdmdimitrov
Copy link
Contributor

Closes #10391

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@igdmdimitrov
Copy link
Contributor Author

@desig9stein, the issue about the parent role is fixed but some other accessibility issues are shown in the excel style filter related to color-contrast. Thoughts?
image

@zhosti zhosti self-assigned this Nov 19, 2021
@zhosti zhosti added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Nov 19, 2021
@igdmdimitrov igdmdimitrov changed the title fix(esf): added role=menu to esf article fix(esf): added role=menu to esf article - master Nov 22, 2021
@kdinev kdinev merged commit ba2b054 into master Nov 22, 2021
@kdinev kdinev deleted the dmdimitrov/fix-10391-master branch November 22, 2021 15:05
@GibletJr
Copy link

Please confirm that this fix will also be included in 12.x versions; and if so, if it will be in 12.3.2.

@igdmdimitrov
Copy link
Contributor Author

Please confirm that this fix will also be included in 12.x versions; and if so, if it will be in 12.3.2.

@GibletJr, yes, the fix is now available in 12.3.1 - https://github.com/IgniteUI/igniteui-angular/releases/tag/12.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aria-support version: 13.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

igx-excel-filter missing valid ARIA parents role
5 participants