New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with reusing a positioning strategy instance across drop downs #3636

Closed
kdinev opened this Issue Jan 16, 2019 · 0 comments

Comments

Projects
None yet
4 participants
@kdinev
Copy link
Member

kdinev commented Jan 16, 2019

Description

When I try to reuse a positioning strategy instance across drop downs, the target of the positioning is always set to the element that triggers the first drop down opening.

  • igniteui-angular version: 7.1.1
  • browser: N/A

Steps to reproduce

  1. Define multiple drop downs
  2. Define multiple elements that toggle each drop down
  3. Define a single overlaySettings instance and provide it to all elements
  4. Open the drop downs one by one

Result

Depending on which drop down is opened first, all the rest open against the first drop down target.

Expected result

Each drop down opens according to its own target,

@wnvko wnvko self-assigned this Jan 23, 2019

wnvko added a commit that referenced this issue Jan 23, 2019

wnvko added a commit that referenced this issue Jan 23, 2019

wnvko added a commit that referenced this issue Jan 23, 2019

wnvko added a commit that referenced this issue Jan 23, 2019

@kdinev kdinev closed this in #3701 Jan 25, 2019

kdinev added a commit that referenced this issue Jan 25, 2019

Toggle action should provide its element as target (#3701)
* test(igxToggle): toggle action should provide its element as target, #3636

* fix(igxToggle): toggle action should provide its element as target, #3636

* docs(igxToggle): update README.md, #3636

* test(igxToggle): fix failing test, #3636

* docs(igxToggle): update CHANGELOG.md, #3636

* chore(igxToggle): remove leftover from spec file

* chore(igxToggle): update README.md

* chore(igxToggle): update CHANGELOG.md

* fix(igxToggle): fix scrolling of multiple toggles, #3636

wnvko added a commit that referenced this issue Jan 29, 2019

wnvko added a commit that referenced this issue Jan 29, 2019

wnvko added a commit that referenced this issue Jan 29, 2019

@wnvko wnvko referenced this issue Jan 29, 2019

Merged

Force toggle action to set target 7.1.x #3754

5 of 5 tasks complete

wnvko added a commit that referenced this issue Jan 29, 2019

@wnvko wnvko referenced this issue Jan 29, 2019

Closed

Force toggle action to set target #3756

4 of 4 tasks complete

wnvko added a commit that referenced this issue Jan 29, 2019

chore(igxToggle): update CHANGELOG.md, #3636
Removing a change which was added in 7.1.4 version and included in CHANGELOG.md
at this version.

@wnvko wnvko referenced this issue Jan 29, 2019

Merged

Update CHANGELOG.md, #3636 #3759

2 of 2 tasks complete

bazal4o added a commit that referenced this issue Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment