Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between light-grid schema and grid-theme #5432

Closed
mmart1n opened this issue Jul 16, 2019 · 0 comments

Comments

@mmart1n
Copy link

commented Jul 16, 2019

Description

  1. sortable-header-icon-hover-color parameter works properly but isn't described in the documentation.
  2. sortable-header-icon-hover-color is a parameter only in _light-grid schema and it is omitted in _grid-theme, so in order to use it you have to extend the _light-grid schema.
  3. sorted-header-color, sortable-header-hover-icon-color, sortable-header-hover-color persist in the _light-grid schema but are never used in the _grid-theme.

Steps to reproduce

Create a custom schema, which extends the _light-grid schema and includes one of the missing parameters.

Result

The styles are not applied.

Expected result

Either include the missing properties to the theme and the documentation, in order to be applicable, or remove them from the source code. Also add sortable-header-icon-hover-color as a parameter in _grid-theme since it is applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.