Skip to content

fix(grid): add addtional check for cellID #11193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 14, 2022
Merged

fix(grid): add addtional check for cellID #11193

merged 6 commits into from
Mar 14, 2022

Conversation

@Volen99
Copy link
Contributor

@Volen99 Volen99 commented Mar 8, 2022 •
edited
Loading

Closes #11154

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@Volen99 Volen99 requested a review from hanastasov March 8, 2022 12:51
@Volen99 Volen99 added 🐛 bug Any issue that describes a bug ❌ status: awaiting-test PRs awaiting manual verification labels Mar 8, 2022
@Svetloslav15 Svetloslav15 added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Mar 9, 2022
Svetloslav15
Svetloslav15 previously approved these changes Mar 9, 2022
View reviewed changes
This was referenced Mar 9, 2022
Merged
Closed
hanastasov
hanastasov previously approved these changes Mar 10, 2022
View reviewed changes
@Volen99 Volen99 mentioned this pull request Mar 10, 2022
Merged
14 tasks
@hanastasov hanastasov removed the ✅ status: verified Applies to PRs that have passed manual verification label Mar 10, 2022
@Volen99 Volen99 mentioned this pull request Mar 14, 2022
Merged
14 tasks
@Volen99 Volen99 dismissed stale reviews from hanastasov and Svetloslav15 via f7a8cf8 March 14, 2022 12:10
@dobromirts dobromirts added the ✅ status: verified Applies to PRs that have passed manual verification label Mar 14, 2022
@hanastasov hanastasov merged commit d2ef28b into master Mar 14, 2022
@hanastasov hanastasov deleted the VDyulgerov/fix-CellEditExit-is-calling-twice branch March 14, 2022 13:32
This was referenced Mar 22, 2022
Merged
Merged
@renovate renovate bot mentioned this pull request Mar 26, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hanastasov hanastasov hanastasov left review comments

+1 more reviewer

@Svetloslav15 Svetloslav15 Svetloslav15 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Svetloslav15 Svetloslav15

Labels

🐛 bug Any issue that describes a bug ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CellEditExit is calling twice when I change to another Cell in different Row

6 participants

@Volen99 @hanastasov @Svetloslav15 @Aleksandyr @dobromirts