Skip to content

fix(grid): add addtional check for cellID #11193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 14, 2022
Merged

fix(grid): add addtional check for cellID #11193

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e682dc9
fix(grid): add addtional check for cellID
Volen99 Mar 8, 2022
a14062c
Merge branch 'master' into VDyulgerov/fix-CellEditExit-is-calling-twice
hanastasov Mar 9, 2022
9ca572f
Merge branch 'master' into VDyulgerov/fix-CellEditExit-is-calling-twice
hanastasov Mar 10, 2022
f7a8cf8
fix(grid): prevent cell edit exit double emit
Volen99 Mar 14, 2022
3fb0fe0
fix(grid): remove not working code
Volen99 Mar 14, 2022
77edc7b
Merge branch 'master' into VDyulgerov/fix-CellEditExit-is-calling-twice
hanastasov Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions projects/igniteui-angular/src/lib/grids/common/crud.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,28 +525,26 @@ export class IgxGridCRUDService extends IgxRowAddCrudState {
this.grid.tbody.nativeElement.focus();
}
} else {

this.createCell(cell);
if (this.rowEditing) {
// TODO rowData
if (this.row && !this.sameRow(this.cell?.id?.rowID)) {
if (this.row && !this.sameRow(cell?.cellID?.rowID)) {
this.rowEditingBlocked = this.endEdit(true, event);
if (this.rowEditingBlocked) {
return true;
}

// If enters here, @endEdit clears the new reference of the cell edit.
this.createCell(cell);
this.rowEditingBlocked = false;
this.endRowEdit();
}
this.createCell(cell);

const canceled = this.beginRowEdit(event);
if (!canceled) {
this.beginCellEdit(event);
}

} else {
this.createCell(cell);
this.beginCellEdit(event);
}
}
Expand Down