Skip to content

PivotGrid Minor performance improvements #11243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2022
Merged

PivotGrid Minor performance improvements #11243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions projects/igniteui-angular/src/lib/directives/for-of/for_of.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1464,6 +1464,9 @@ export class IgxGridForOfDirective<T> extends IgxForOfDirective<T> implements On
@Input()
public igxGridForOfUniqueSizeCache = false;

@Input()
public igxGridForOfVariableSizes = true;

public get igxGridForOf() {
return this.igxForOf;
}
Expand Down Expand Up @@ -1494,6 +1497,12 @@ export class IgxGridForOfDirective<T> extends IgxForOfDirective<T> implements On
return this.igxForSizePropName || 'height';
}

public recalcUpdateSizes() {
if (this.igxGridForOfVariableSizes) {
super.recalcUpdateSizes();
}
}

/**
* @hidden @internal
* An event that is emitted after data has been changed but before the view is refreshed
Expand Down
1 change: 1 addition & 0 deletions projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
let-rowIndex="index" [igxForScrollOrientation]="'vertical'" [igxForScrollContainer]='verticalScroll'
[igxForContainerSize]='calcHeight'
[igxForItemSize]="hasColumnLayouts ? rowHeight * multiRowLayoutRowSize + 1 : renderedRowHeight"
[igxGridForOfVariableSizes]='false'
#verticalScrollContainer>
<ng-template
[igxTemplateOutlet]='recordTemplate'
Expand Down
2 changes: 1 addition & 1 deletion projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-header-row.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ export class IgxPivotHeaderRowComponent extends IgxGridHeaderRowComponent implem
*/
public getAreaHeight(area: IgxChipsAreaComponent) {
const chips = area.chipsList;
return chips && chips.length > 0 ? chips.first.nativeElement.clientHeight : 0;
return chips && chips.length > 0 ? chips.first.nativeElement.offsetHeight : 0;
}

/**
Expand Down