Skip to content

refactor(input): use border instead of box-shadow #11273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 24, 2022
Merged

refactor(input): use border instead of box-shadow #11273

merged 7 commits into from
Mar 24, 2022

Conversation

@SisIvanova
Copy link
Collaborator

@SisIvanova SisIvanova commented Mar 23, 2022

Closes #11256

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@SisIvanova SisIvanova marked this pull request as ready for review March 24, 2022 12:58
@SisIvanova SisIvanova added the ❌ status: awaiting-test PRs awaiting manual verification label Mar 24, 2022
@SisIvanova SisIvanova requested a review from simeonoff March 24, 2022 12:59
simeonoff
simeonoff previously approved these changes Mar 24, 2022
View reviewed changes
@simeonoff simeonoff changed the base branch from master to 13.1.x March 24, 2022 13:31
@simeonoff simeonoff dismissed their stale review March 24, 2022 13:31

The base branch was changed.

@simeonoff simeonoff self-requested a review March 24, 2022 13:43
@simeonoff simeonoff added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Mar 24, 2022
@simeonoff simeonoff merged commit d901c3d into 13.1.x Mar 24, 2022
@simeonoff simeonoff deleted the sivanova/fluent-input branch March 24, 2022 14:49
@SisIvanova SisIvanova mentioned this pull request Mar 28, 2022
Closed
This was referenced Mar 29, 2022
Merged
Merged
@renovate renovate bot mentioned this pull request Apr 11, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simeonoff simeonoff simeonoff approved these changes

Assignees

No one assigned

Labels

fluent-theme input-group refactoring version: 13.1.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fluent Input uses box-shadow instead of borders

3 participants

@SisIvanova @simeonoff