Skip to content

fix(igxGrid): Minor fix and refactor for row adding APIs. #11279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2022
Merged

fix(igxGrid): Minor fix and refactor for row adding APIs. #11279

merged 2 commits into from
Mar 25, 2022

Conversation

@MayaKirova
Copy link
Contributor

@MayaKirova MayaKirova commented Mar 24, 2022

Closes #10118

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@MayaKirova MayaKirova added ❌ status: awaiting-test PRs awaiting manual verification grid: row-adding labels Mar 24, 2022
@MayaKirova MayaKirova requested a review from dkamburov March 24, 2022 14:45
@mddragnev mddragnev added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Mar 24, 2022
@mddragnev
Copy link
Member

mddragnev commented Mar 25, 2022

@MayaKirova A test within the add row feature is failing. Could you please check it?

@mddragnev mddragnev added awaiting author When the reviewer/verifier has some confusions about the scenario/behavior and wait author's action and removed 💥 status: in-test PRs currently being tested labels Mar 25, 2022
chore(*): Fix test as it seems that when null is passed adding UI sho…
5de9152 
…uld show for null row and not for row at 0 index.
@MayaKirova MayaKirova added ❌ status: awaiting-test PRs awaiting manual verification and removed awaiting author When the reviewer/verifier has some confusions about the scenario/behavior and wait author's action labels Mar 25, 2022
@mddragnev mddragnev added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Mar 25, 2022
@dkamburov dkamburov merged commit 47bafd5 into 13.1.x Mar 25, 2022
@dkamburov dkamburov deleted the mkirova/fix-10118 branch March 25, 2022 17:22
This was referenced Mar 29, 2022
Merged
Merged
@renovate renovate bot mentioned this pull request Apr 11, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkamburov dkamburov dkamburov approved these changes

Assignees

@dkamburov dkamburov

@mddragnev mddragnev

Labels

grid: row-adding ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MayaKirova @mddragnev @dkamburov