From b4f1285d0bd8be90f74d75e2a98a3e361a5a4a5e Mon Sep 17 00:00:00 2001 From: MKirova Date: Thu, 8 Sep 2022 17:07:30 +0300 Subject: [PATCH 1/3] chore(*): Add aria-describedby reference to error message element as well since readers are more likely to read it than aria-errormessage. --- .../igniteui-angular/src/lib/grids/cell.component.html | 10 ++++++++++ .../igniteui-angular/src/lib/grids/cell.component.ts | 3 +++ .../src/lib/grids/grid/expandable-cell.component.html | 10 ++++++++++ .../src/lib/grids/tree-grid/tree-cell.component.html | 10 ++++++++++ 4 files changed, 33 insertions(+) diff --git a/projects/igniteui-angular/src/lib/grids/cell.component.html b/projects/igniteui-angular/src/lib/grids/cell.component.html index 40837dfd5eb..d6217201af6 100644 --- a/projects/igniteui-angular/src/lib/grids/cell.component.html +++ b/projects/igniteui-angular/src/lib/grids/cell.component.html @@ -75,6 +75,8 @@ Date: Thu, 8 Sep 2022 18:32:55 +0300 Subject: [PATCH 2/3] chore(*): Test with removing aria-describeby that points to the header. Also remove aria-errormessage since it's not supported. --- .../igniteui-angular/src/lib/grids/cell.component.html | 5 ----- .../igniteui-angular/src/lib/grids/cell.component.ts | 10 +--------- .../src/lib/grids/grid/expandable-cell.component.html | 5 ----- .../src/lib/grids/grid/grid-row.component.html | 6 ++---- .../hierarchical-grid/hierarchical-row.component.html | 4 ++-- .../src/lib/grids/pivot-grid/pivot-row.component.html | 2 +- .../src/lib/grids/summaries/summary-row.component.html | 2 -- .../src/lib/grids/tree-grid/tree-cell.component.html | 5 ----- .../lib/grids/tree-grid/tree-grid-row.component.html | 4 ---- 9 files changed, 6 insertions(+), 37 deletions(-) diff --git a/projects/igniteui-angular/src/lib/grids/cell.component.html b/projects/igniteui-angular/src/lib/grids/cell.component.html index d6217201af6..bd6b3667acd 100644 --- a/projects/igniteui-angular/src/lib/grids/cell.component.html +++ b/projects/igniteui-angular/src/lib/grids/cell.component.html @@ -74,7 +74,6 @@ {{ currencyCodeSymbol }} {{ currencyCodeSymbol }} {{ currencyCodeSymbol }} Date: Fri, 9 Sep 2022 14:59:43 +0300 Subject: [PATCH 3/3] chore(*): Update so that describeby includes both header ref and arror elem ref. --- .../igniteui-angular/src/lib/grids/cell.component.html | 10 +++++----- .../igniteui-angular/src/lib/grids/cell.component.ts | 9 +++++++++ .../src/lib/grids/grid/expandable-cell.component.html | 10 +++++----- .../src/lib/grids/tree-grid/tree-cell.component.html | 10 +++++----- 4 files changed, 24 insertions(+), 15 deletions(-) diff --git a/projects/igniteui-angular/src/lib/grids/cell.component.html b/projects/igniteui-angular/src/lib/grids/cell.component.html index bd6b3667acd..7f73186d700 100644 --- a/projects/igniteui-angular/src/lib/grids/cell.component.html +++ b/projects/igniteui-angular/src/lib/grids/cell.component.html @@ -74,7 +74,7 @@ {{ currencyCodeSymbol }} {{ currencyCodeSymbol }} {{ currencyCodeSymbol }}