Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(simple-combo): Update the model value only if selection is changed #14247

Merged
merged 4 commits into from
Jun 3, 2024
Merged

fix(simple-combo): Update the model value only if selection is changed #14247

merged 4 commits into from
Jun 3, 2024

Conversation

IvanKitanov17
Copy link
Contributor

@IvanKitanov17 IvanKitanov17 commented May 21, 2024 •
edited by jackofdiamond5
Loading

Closes #14053

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@IvanKitanov17 IvanKitanov17 marked this pull request as draft May 21, 2024 10:41
@IvanKitanov17 IvanKitanov17 marked this pull request as ready for review May 21, 2024 12:06
@jackofdiamond5 jackofdiamond5 added the squash-merge Merge PR with "Squash and Merge" option label May 22, 2024
@kacheshmarova kacheshmarova merged commit 3208f2c into 16.1.x Jun 3, 2024
6 checks passed
@kacheshmarova kacheshmarova deleted the ikitanov/fix-14053-16.1.x branch June 3, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackofdiamond5 jackofdiamond5 jackofdiamond5 approved these changes

Assignees
No one assigned
Labels
simple-combo squash-merge Merge PR with "Squash and Merge" option version: 16.1.x ❌ status: awaiting-test PRs awaiting manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IvanKitanov17 @jackofdiamond5 @kacheshmarova