From c04dcdbb3a288768da40f86ac4828b12c1a515b6 Mon Sep 17 00:00:00 2001 From: Georgi Anastasov Date: Thu, 19 Sep 2024 12:25:18 +0300 Subject: [PATCH 1/2] chore(grid, pivot): add deprecation proxy for shouldGenerate to autoGenerate --- .../src/lib/grids/grid-base.directive.ts | 10 ++++++++-- .../src/lib/grids/pivot-grid/pivot-grid.component.ts | 10 ++++++++-- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/projects/igniteui-angular/src/lib/grids/grid-base.directive.ts b/projects/igniteui-angular/src/lib/grids/grid-base.directive.ts index 70e144574ae..bae8a269d09 100644 --- a/projects/igniteui-angular/src/lib/grids/grid-base.directive.ts +++ b/projects/igniteui-angular/src/lib/grids/grid-base.directive.ts @@ -2197,9 +2197,15 @@ export abstract class IgxGridBaseDirective implements GridType, * ```typescript * this.grid.shouldGenerate = true; * ``` - * @deprecated in version 18.2.0. Use the `autoGenerate` property instead. + * @deprecated in version 18.2.0. Column re-creation now relies on `autoGenerate` instead. */ - public shouldGenerate: boolean; + public get shouldGenerate(): boolean { + return this.autoGenerate; + } + + public set shouldGenerate(value: boolean) { + this.autoGenerate = value; + } /** * Gets/Sets the message displayed when there are no records and the grid is filtered. diff --git a/projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid.component.ts b/projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid.component.ts index 824c6e305c5..913d097fe76 100644 --- a/projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid.component.ts +++ b/projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid.component.ts @@ -745,9 +745,15 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni /** * @hidden @internal - * @deprecated in version 18.2.0. Use the `autoGenerate` property instead. + * @deprecated in version 18.2.0. Column re-creation now relies on `autoGenerate` instead. */ - public override shouldGenerate: boolean; + public override get shouldGenerate(): boolean { + return this.autoGenerate; + } + + public override set shouldGenerate(value: boolean) { + this.autoGenerate = value; + } /** * @hidden @internal From 43f6311cdd6c4d21a8e1c1bf048afd66fa765200 Mon Sep 17 00:00:00 2001 From: Georgi Anastasov Date: Thu, 19 Sep 2024 14:00:22 +0300 Subject: [PATCH 2/2] refactor(pivot): remove deprecated shouldGenerate property --- .../src/lib/grids/pivot-grid/pivot-grid.component.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid.component.ts b/projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid.component.ts index 913d097fe76..b6e9e14c85c 100644 --- a/projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid.component.ts +++ b/projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid.component.ts @@ -745,14 +745,13 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni /** * @hidden @internal - * @deprecated in version 18.2.0. Column re-creation now relies on `autoGenerate` instead. + * @deprecated in version 18.2.0. This property is no longer supported. */ public override get shouldGenerate(): boolean { - return this.autoGenerate; + return false; } public override set shouldGenerate(value: boolean) { - this.autoGenerate = value; } /**