Skip to content

Change static flag for templates to false - 8.1.x #5616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 12, 2019
Merged

Change static flag for templates to false - 8.1.x #5616

merged 4 commits into from
Aug 12, 2019

Conversation

@nrobakova
Copy link
Contributor

@nrobakova nrobakova commented Aug 8, 2019

Closes #5550

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@nrobakova nrobakova added list nav-drawer 🛠️ status: in-development Issues and PRs with active development on them grid: general 📅 date-picker tabs combo version: 8.1.x ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Aug 8, 2019
damyanpetev
damyanpetev previously approved these changes Aug 8, 2019
View reviewed changes
Copy link
Member

@damyanpetev damyanpetev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Guessing those went in with the automatic migrations (-_-)

@zdrawku zdrawku added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Aug 12, 2019
@zdrawku zdrawku added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Aug 12, 2019
@zdrawku zdrawku merged commit ac6547a into 8.1.x Aug 12, 2019
@zdrawku zdrawku deleted the nrobakova/fix-issue-5550-8.1.x branch August 12, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zdrawku zdrawku zdrawku approved these changes

@damyanpetev damyanpetev damyanpetev left review comments

@rkaraivanov rkaraivanov Awaiting requested review from rkaraivanov

Assignees

@zdrawku zdrawku

Labels

combo 📅 date-picker grid: general list nav-drawer tabs version: 8.1.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nrobakova @damyanpetev @zdrawku