-
Notifications
You must be signed in to change notification settings - Fork 156
Add seconds support for time-picker component #5721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Lipata Please assign somebody to test this PR. |
|
@Tian-Hun There seems to be a problem with the parsing of the input value's seconds - when you edit the seconds and expand the time picker, the changes are not reflected. Another thing that happens is when you expand the time picker and try to select a different value for the seconds, it updates the minutes' value instead. |
|
Ok, I understand and fix it. |
|
@Tian-Hun Thanks! Ask away if you need help. |
|
@damyanpetev Thank you for your reminder, I will modify it. |
- rename hours_pos, minutes_pos, seconds_pos, ampm_pos
wnvko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This component should be strongly refactored
projects/igniteui-angular/src/lib/time-picker/time-picker.component.ts
Outdated
Show resolved
Hide resolved
|
Hello everyone! |
|
Hi, @DSergii. When we develop features, we develop them for the upcoming versions - which in the case with the seconds list means that it was developed for version 9.0.0 and above. You can see that it was initially released with 9.0.0-beta.7. |
|
@DSergii, you can follow our Update Guide and ask if you have some problems. We have migrations, the same way as Angular has, and if something needs to be done manually, it is described in the document above. |
|
Thank you @Lipata, but unfortunately, I can't update angular version and seems 9.0.0-beta.7 will not work with angular 8.2+ |
Closes #
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes