Skip to content

Conversation

@Tian-Hun
Copy link
Contributor

Closes #

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

simeonoff
simeonoff previously approved these changes Sep 25, 2019
kdinev
kdinev previously approved these changes Sep 25, 2019
@kdinev kdinev dismissed stale reviews from simeonoff and themself via b5557c8 September 25, 2019 08:42
kdinev
kdinev previously approved these changes Sep 25, 2019
@kdinev
Copy link
Member

kdinev commented Sep 25, 2019

@Lipata Please assign somebody to test this PR.

@jackofdiamond5 jackofdiamond5 added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Sep 25, 2019
@jackofdiamond5
Copy link
Member

@Tian-Hun There seems to be a problem with the parsing of the input value's seconds - when you edit the seconds and expand the time picker, the changes are not reflected. Another thing that happens is when you expand the time picker and try to select a different value for the seconds, it updates the minutes' value instead.

@jackofdiamond5 jackofdiamond5 added 🛠️ status: in-development Issues and PRs with active development on them and removed 💥 status: in-test PRs currently being tested labels Sep 25, 2019
@Tian-Hun
Copy link
Contributor Author

Ok, I understand and fix it.

@damyanpetev
Copy link
Member

@Tian-Hun Thanks!
While at it, do you mind renaming all the "second-" names to "seconds-" just so it won't be confused with secondary/another (e.g. secondList -> secondsList, selectedSecond*s*, etc)?

Ask away if you need help.

@Tian-Hun
Copy link
Contributor Author

@damyanpetev Thank you for your reminder, I will modify it.

@Lipata Lipata requested a review from wnvko December 10, 2019 09:13
- rename hours_pos, minutes_pos, seconds_pos, ampm_pos
wnvko
wnvko previously approved these changes Dec 11, 2019
Copy link
Contributor

@wnvko wnvko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component should be strongly refactored

wnvko
wnvko previously approved these changes Dec 12, 2019
@dafo dafo added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Dec 12, 2019
@Lipata Lipata requested a review from wnvko December 12, 2019 14:35
@dafo dafo added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Dec 13, 2019
@Lipata Lipata merged commit b6468e4 into IgniteUI:master Dec 16, 2019
@DSergii
Copy link

DSergii commented Sep 23, 2020

Hello everyone!
@wnvko Wich igniteui-angular version support seconds? I need it for angular 8.2+
I've tried with "igniteui-angular": "8.2.31", but it doesn't support seconds.
Higher versions of "igniteui-angular", like 9+, doesn't work with angular 8.2+

@Lipata
Copy link
Member

Lipata commented Sep 23, 2020

Hi, @DSergii.

When we develop features, we develop them for the upcoming versions - which in the case with the seconds list means that it was developed for version 9.0.0 and above. You can see that it was initially released with 9.0.0-beta.7.

@Lipata
Copy link
Member

Lipata commented Sep 23, 2020

@DSergii, you can follow our Update Guide and ask if you have some problems. We have migrations, the same way as Angular has, and if something needs to be done manually, it is described in the document above.

@DSergii
Copy link

DSergii commented Sep 23, 2020

Thank you @Lipata, but unfortunately, I can't update angular version and seems 9.0.0-beta.7 will not work with angular 8.2+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🕐 time-picker version: 8.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.