From 24a0aa784ca20eb9d6947ffca2ee5d176bc196d8 Mon Sep 17 00:00:00 2001
From: Simeon Simeonoff <sim.simeonoff@gmail.com>
Date: Fri, 13 Sep 2019 11:04:42 +0300
Subject: [PATCH] refactor(badge): remove `$disable-shadow` property from theme

BREAKING CHANGE: $disable-shadow is no longer part of the badge theme
Closes 5723
---
 CHANGELOG.md                                              | 3 +++
 .../migrations/update-8_2_0/changes/theme-props.json      | 8 ++++++++
 .../lib/core/styles/components/badge/_badge-theme.scss    | 6 ------
 3 files changed, 11 insertions(+), 6 deletions(-)
 create mode 100644 projects/igniteui-angular/migrations/update-8_2_0/changes/theme-props.json

diff --git a/CHANGELOG.md b/CHANGELOG.md
index b1de5bb6a92..b1f5e807d64 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -25,6 +25,9 @@ Next example shows how you can use the Fluent theme.
 }
 ```
 
+### Theme Changes
+`igx-badge-theme` - Removed the `$disable-shadow` property to mitigate confusion when specifying `$shadow` explicitly.
+
 For more information about the theming please read our [documentation](https://www.infragistics.com/products/ignite-ui-angular/angular/components/themes/index.html)  
 
 ### New Features
diff --git a/projects/igniteui-angular/migrations/update-8_2_0/changes/theme-props.json b/projects/igniteui-angular/migrations/update-8_2_0/changes/theme-props.json
new file mode 100644
index 00000000000..f76370fa493
--- /dev/null
+++ b/projects/igniteui-angular/migrations/update-8_2_0/changes/theme-props.json
@@ -0,0 +1,8 @@
+{
+    "$schema": "../../common/schema/theme-props.schema.json",
+    "changes": [{
+        "name": "$disable-shadow",
+        "remove": true,
+        "owner": "igx-badge-theme"
+    }]
+}
diff --git a/projects/igniteui-angular/src/lib/core/styles/components/badge/_badge-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/badge/_badge-theme.scss
index 77800471c3d..68bd52abc29 100644
--- a/projects/igniteui-angular/src/lib/core/styles/components/badge/_badge-theme.scss
+++ b/projects/igniteui-angular/src/lib/core/styles/components/badge/_badge-theme.scss
@@ -15,7 +15,6 @@
 /// @param {Color} $text-color [null] - The text color used.
 /// @param {Color} $border-color [null] - The border color used.
 /// @param {Color} $background-color [null] - The background color used.
-/// @param {Bool} $disable-shadow [true] - Sets the badge shadow visibility.
 /// @param {Bool} $disable-border [true] - Sets the badge border visibility.
 /// @param {box-shadow} $shadow [null] - Sets a shadow to be used for the badge.
 /// @param {border-radius} $border-radius [null] - The border radius used for badge component.
@@ -52,7 +51,6 @@
     $background-color: null,
     $shadow: null,
 
-    $disable-shadow: true,
     $disable-border: true
 ) {
     $name: 'igx-badge';
@@ -77,10 +75,6 @@
         $shadow: igx-elevation($elevations, $elevation);
     }
 
-    @if $disable-shadow {
-        $shadow: none;
-    }
-
     @return extend($theme, (
         name: $name,
         palette: $palette,