From 8dfbbbb8c23980e67a29633ebe1f602ef89b2bdf Mon Sep 17 00:00:00 2001 From: MPopov Date: Wed, 20 Nov 2019 15:12:34 +0200 Subject: [PATCH 1/2] feat(slider): Fix slider position inside grid cell Closes #5973 Signed-off-by: MPopov --- .../lib/core/styles/components/slider/_slider-theme.scss | 1 + .../igniteui-angular/src/lib/slider/slider.component.ts | 7 +------ 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/projects/igniteui-angular/src/lib/core/styles/components/slider/_slider-theme.scss b/projects/igniteui-angular/src/lib/core/styles/components/slider/_slider-theme.scss index 9f9fa0b98b2..0804499c5df 100644 --- a/projects/igniteui-angular/src/lib/core/styles/components/slider/_slider-theme.scss +++ b/projects/igniteui-angular/src/lib/core/styles/components/slider/_slider-theme.scss @@ -128,6 +128,7 @@ display: flex; position: relative; height: rem($slider-height); + flex-grow: 1; align-items: center; transition: all .2s $ease-out-quad; diff --git a/projects/igniteui-angular/src/lib/slider/slider.component.ts b/projects/igniteui-angular/src/lib/slider/slider.component.ts index eb157caedd2..1fd5171d977 100644 --- a/projects/igniteui-angular/src/lib/slider/slider.component.ts +++ b/projects/igniteui-angular/src/lib/slider/slider.component.ts @@ -51,12 +51,7 @@ let NEXT_ID = 0; @Component({ providers: [{ provide: NG_VALUE_ACCESSOR, useExisting: IgxSliderComponent, multi: true }], selector: 'igx-slider', - templateUrl: 'slider.component.html', - styles: [` - :host { - display: block; - } - `] + templateUrl: 'slider.component.html' }) export class IgxSliderComponent implements ControlValueAccessor, From 205e19f72aadb83c4f4cf9bca47b3b3c2f1d41dd Mon Sep 17 00:00:00 2001 From: ddincheva Date: Thu, 21 Nov 2019 13:55:29 +0200 Subject: [PATCH 2/2] test(IgxSlider): add the missing change detection in the tests #5973 --- .../igniteui-angular/src/lib/slider/slider.component.spec.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/projects/igniteui-angular/src/lib/slider/slider.component.spec.ts b/projects/igniteui-angular/src/lib/slider/slider.component.spec.ts index ab2c7949983..a31a701ef1b 100644 --- a/projects/igniteui-angular/src/lib/slider/slider.component.spec.ts +++ b/projects/igniteui-angular/src/lib/slider/slider.component.spec.ts @@ -638,6 +638,7 @@ describe('IgxSlider', () => { it('tick marks(steps) should be shown equally spread based on labels length', () => { const ticks = fixture.nativeElement.querySelector('.igx-slider__track-ticks'); const sliderWidth = parseInt(fixture.nativeElement.querySelector('igx-slider').clientWidth, 10); + fixture.detectChanges(); expect(slider.type).toBe(SliderType.SLIDER); expect(ticks).toBeDefined(); @@ -922,6 +923,7 @@ describe('IgxSlider', () => { it('tick marks(steps) should be shown equally spread based on labels length', () => { const ticks = fixture.nativeElement.querySelector('.igx-slider__track-ticks'); const sliderWidth = parseInt(fixture.nativeElement.querySelector('igx-slider').clientWidth, 10); + fixture.detectChanges(); expect(slider.type).toBe(SliderType.RANGE); expect(ticks).not.toBeNull();