Skip to content

Conversation

@damyanpetev
Copy link
Member

Closes #6227
This slipped through the Angular 9 update. Migrations applied @Directive to base classes with any sort of binding and since the IgxBaseExporter had emitters decorated with @Output, ¯\(ツ)/¯, migrations must've considered it as a component base. Both decorators have been removed.

And since I semi-batch renamed classes with added Directives for lint, I'm rolling back the rename as well. I'll revert docs links if required too.

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@astaev astaev added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 29, 2019
@astaev astaev added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Nov 29, 2019
@Lipata Lipata merged commit 7565799 into master Nov 29, 2019
@Lipata Lipata deleted the dpetev/exporter-decorator-revert branch November 29, 2019 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exporters version: 9.0.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ERROR in Directive IgxCsvExporterService

5 participants