Skip to content

fix(dropdown): Removing shadow only for --select mod #6276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rkaraivanov merged 7 commits into from
Dec 5, 2019
Merged

fix(dropdown): Removing shadow only for --select mod #6276

rkaraivanov merged 7 commits into from
Dec 5, 2019

Conversation

@desig9stein
Copy link
Contributor

@desig9stein desig9stein commented Dec 3, 2019 •
edited
Loading

Closes #6270

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

simeonoff
simeonoff requested changes Dec 4, 2019
View reviewed changes
Copy link
Collaborator

@simeonoff simeonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue, but introduces other problems. Not exactly the solution I was looking forward to.

@simeonoff simeonoff self-requested a review December 4, 2019 13:46
@simeonoff simeonoff self-assigned this Dec 5, 2019
@simeonoff simeonoff added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Dec 5, 2019
@rkaraivanov rkaraivanov merged commit 4153f03 into master Dec 5, 2019
@rkaraivanov rkaraivanov deleted the fix-for-#6270 branch December 5, 2019 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simeonoff simeonoff simeonoff approved these changes

@kdinev kdinev Awaiting requested review from kdinev

Assignees

@simeonoff simeonoff

@rkaraivanov rkaraivanov

Labels

dropdown version: 9.0.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing elevation style on dropdown components

4 participants

@desig9stein @simeonoff @rkaraivanov