Skip to content

fix(esf): convert values to string before applying toLowerCase #8421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2020
Merged

fix(esf): convert values to string before applying toLowerCase #8421

merged 1 commit into from
Oct 20, 2020

Conversation

@onlyexeption
Copy link
Contributor

@onlyexeption onlyexeption commented Oct 20, 2020

Closes #8420

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@DiyanDimitrov DiyanDimitrov self-assigned this Oct 20, 2020
@DiyanDimitrov DiyanDimitrov added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 20, 2020
@DiyanDimitrov DiyanDimitrov merged commit f9e4d99 into master Oct 20, 2020
@DiyanDimitrov DiyanDimitrov deleted the ibarakov/fix-8420-master branch October 20, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@DiyanDimitrov DiyanDimitrov DiyanDimitrov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@DiyanDimitrov DiyanDimitrov

Labels

grid: excel-style-filtering grid: general grid: tree-grid version: 10.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Excel Style Filtering throws error for column with numeric values and dataType string

3 participants

@onlyexeption @DiyanDimitrov