Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint errors for generated angular projects #553

Merged
merged 4 commits into from Sep 12, 2019
Merged

Fix lint errors for generated angular projects #553

merged 4 commits into from Sep 12, 2019

Conversation

PlamenaMiteva
Copy link
Contributor

@PlamenaMiteva PlamenaMiteva commented Sep 4, 2019 •
edited by damyanpetev

Closes #541.

@coveralls
Copy link

coveralls commented Sep 9, 2019 •
edited

Coverage Status

Coverage remained the same at 87.09% when pulling e7d5084 on PMiteva/fix-lint-errors into 0f5d0e1 on master.

@damyanpetev damyanpetev self-requested a review September 11, 2019 07:19
@ViktorSlavov
Copy link
Contributor

ViktorSlavov commented Sep 11, 2019 •
edited

@PlamenaMiteva , there seem to be some files that were missed in the Authentication project. Most of them are .spec files, which might even be addressed in the test fix PR, but some errors are in the component files - please take a look when you have the time.

There' s also a failing file in the combo template - local-data.ts;

damyanpetev
damyanpetev approved these changes Sep 12, 2019
View reviewed changes
Copy link
Member

@damyanpetev damyanpetev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damyanpetev damyanpetev merged commit b2bbc2e into master Sep 12, 2019
@damyanpetev damyanpetev deleted the PMiteva/fix-lint-errors branch September 12, 2019 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damyanpetev damyanpetev damyanpetev approved these changes

@Lipata Lipata Awaiting requested review from Lipata

Assignees

@ViktorSlavov ViktorSlavov

Labels
angular ✅ status: verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix lint errors for generated projects
4 participants
@PlamenaMiteva @coveralls @ViktorSlavov @damyanpetev