Permalink
Commits on May 15, 2018
Commits on Apr 22, 2018
  1. remove unneeded thumbnail_requests list ptk-file-list.c

    IgnorantGuru committed Apr 22, 2018
    Apparently vfs_thumbnail_loader_request() is thread-safe after all.  It
    appears the thread race re g_slist_prepend was causing the issue in
    g_slice_new0, so the thumbnail_requests addition has been removed.
  2. add mutex locks for ptk-file-list.c file update lists

    IgnorantGuru committed Apr 22, 2018
    This seems to correct a thread race that is occuring on the file lists
Commits on Apr 21, 2018
  1. test ptkfilelist lists to handle non-thread-safe

    IgnorantGuru committed Apr 21, 2018
    This attempt crashes on magazine pop in on_event_timer due to non-thread-safe
    g_slice_now0 and g_slist_prepend?
Commits on Apr 20, 2018
  1. fix thread races causing dir not finalized, idle uses, adds FIXME

    IgnorantGuru committed Apr 20, 2018
    dir object not being finalized was caused by thread races due to
    non-thread-safe idle functions within GTK functions.  These have been removed.
    
    Remaining thread race - See new FIXME note in ptk_file_list_file_changed()
    
    Removed debug output
  2. remove use of main loop idle in async task and thumbnail loader; debu…

    IgnorantGuru committed Apr 20, 2018
    …g info
    
    This commit is a partial work save, with debug output still enabled.
    
    Remaining issues after this commit:
    * dir object not always finalizing under extreme tests
    * use of gtk_widget_queue_draw in on_dir_file_listed not thread-safe
Commits on Apr 19, 2018
Commits on Apr 18, 2018
  1. redesign status bar update based on timer

    IgnorantGuru committed Apr 18, 2018
    Use of g_idle_add with multiple threads causing issues on status bar updates
    during refresh and dir load, so use an event timer for the main window instead.
    This handles the issue of content and selection change signals firing too
    often when many files are selected.
Commits on Apr 5, 2018
  1. fix vfs_dir_finalize order to prevent dangling inotify callback crash

    IgnorantGuru committed Apr 5, 2018
    Changes in alpha reordered vfs_dir_finalize steps (why?) which caused a crash due to
    freeing object data and removing file alteration monitor callback before canceling dir
    task. This caused a dangling callback and data problems in vfs_dir_load_thread() on early
    load cancel.
    
    To reproduce original crash, set a script to create and delete files rapidly in current
    dir as dir is being rapidly moved into and out of, or refreshed, in SpaceFM.  This bug
    does not generally appear reproducible except under extreme test conditions, but may
    have caused occasional temporary hangs, inotify issues, or other rare issues in alpha.
  2. fix non-thread-safe vfs_dir_load_thread strcmp sort crash #582 #602 #673

    IgnorantGuru committed Apr 5, 2018
    
    
    rough sort of file_list_copy crashed on strcmp due to collate key update triggered by
    file change signal during dir load.
Commits on Mar 19, 2018
  1. fix non-thread-safe ptk-file-browser.c on_content_changed #582 #602 #673

    IgnorantGuru committed Mar 19, 2018
    
    
    crashed due to
    Thread 1: in on_folder_view_item_sel_change_idle called from main loop
    Thread 2: in on_thumbnail_loaded from vfs_dir_load_thread
    
    Gdk:ERROR:/build/gtk+2.0-1aCJs4/gtk+2.0-2.24.31/gdk/gdkregion-generic.c:1110
              :miUnionNonO: assertion failed: (y1 < y2)
Commits on Mar 8, 2018
  1. follow XDG thumbnail spec #642; raise smart queue limit 100M/10G

    IgnorantGuru committed Mar 8, 2018
    Use $XDG_CACHE_HOME/thumbnails/ instead of ~/.thumbnails/
    Use thumbnails/large/ for > 128
    Delete thumbnails when deleting files
    Raise smart queue copy/move limit to 100 MB, delete limit to 10 GB
Commits on Mar 4, 2018
  1. Merge branch 'next' into alpha

    IgnorantGuru committed Mar 4, 2018
    Conflicts:
    	ChangeLog
    	configure
    	configure.ac
    	data/spacefm-manual-en.html
  2. start 1.0.6+next

    IgnorantGuru committed Mar 4, 2018
  3. release 1.0.6

    IgnorantGuru committed Mar 4, 2018
Commits on Feb 24, 2018
  1. fix crashes due to non-thread-safe status bar update #582 #602 #673

    IgnorantGuru committed Feb 24, 2018
    See code comment in ptk-file-browser.c:2997
    Also speed up files_compare() in vfs-dir.c
    Add debug msg on NULL collate keys in vfs-file-info.c
Commits on Feb 20, 2018
Commits on Feb 19, 2018
Commits on Feb 18, 2018
Commits on Feb 16, 2018
Commits on Feb 11, 2018
Commits on Feb 8, 2018
  1. fix regression de7bead #648

    IgnorantGuru committed Feb 8, 2018