Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome-terminal no longer accepts '--disable-factory' #428

Closed
OmegaPhil opened this issue Feb 27, 2014 · 4 comments
Closed

gnome-terminal no longer accepts '--disable-factory' #428

OmegaPhil opened this issue Feb 27, 2014 · 4 comments
Labels
Milestone

Comments

@OmegaPhil
Copy link
Contributor

I've started working in a VM to investigate the desktop bugs for hand, so I have a pretty default config.

Looks like gnome-terminal has arguments churn making it unusable currently (no terminal appears):

SPAWN=/usr/bin/gnome-terminal  --disable-factory  -x  /bin/bash  /tmp/spacefm-omega-3b9879a5.tmp/7071b784-tmp.sh  run
    pid = 6873
Failed to parse arguments: Option "--disable-factory" is no longer supported in this version of gnome-terminal.

Version: GNOME Terminal 3.10.1

@IgnorantGuru
Copy link
Owner

Fortunately no one uses GNOME terminal 3. ;)

The --disable-factory is used by spacefm to insure that the terminal it is starting is a new instance, rather than just a new window in an existing instance. This way SpaceFM can tell when the command executed in the terminal has finished. This mostly affects using Popup Task and Run In Terminal together.

The are a few other terminals that can't do this, so SpaceFM has workarounds for them, although some functionality (such as Popup Task and Run In Terminal together) is lost.

So the question is, does GNOME Terminal 3 have an option to replace --disable-factory that ensures a new instance is started, or have they removed the ability altogether? (My guess is the latter. ;)

@IgnorantGuru IgnorantGuru added this to the 0.9.4 milestone Feb 28, 2014
@OmegaPhil
Copy link
Contributor Author

Looks like they cant be bothered: https://mail.gnome.org/archives/commits-list/2013-September/msg05584.html

I won't be investigating further - as you know, I use roxterm.

@IgnorantGuru
Copy link
Owner

Should be good in next - would appreciate a quick test- thanks.

@OmegaPhil
Copy link
Contributor Author

I can confirm this now works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants