Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mime type icons not read from .../mime/packages #530

Closed
IgnorantGuru opened this issue May 14, 2015 · 2 comments
Closed

mime type icons not read from .../mime/packages #530

IgnorantGuru opened this issue May 14, 2015 · 2 comments
Labels
Milestone

Comments

@IgnorantGuru
Copy link
Owner

Received elsewhere:

I'm having an issue with this otherwise fantastic file manager. My problem is related to file icons: I changed the icons associated with some file types (like LibreOffice files, html files, etc.) by modifying the "icon name" in the respective xml files, for example for LibreOffice Calc it looks like this in '~/.local/share/mime/packages/application-vnd.oasis.opendocument.spreadsheet.xml':

Then I used the "File -> Open" dialog in several programs (Firefox, LibreOffice, Geany, etc.) and it perfectly shows the newly configurated icons, yet Spacefm still uses the old ones even after restarting it.

I'm just using Openbox without any desktop environment. The icons that I use and that Spacefm doesn't show are not new, they are part of the Gnome icon theme that is the default on my system.

Is this a bug or is there something more I need to do?

@IgnorantGuru IgnorantGuru added this to the 1.0.2 milestone May 14, 2015
@IgnorantGuru
Copy link
Owner Author

This should be fixed in dd1db2c - currently in the next branch, due for 1.0.2 release. To test please see BUILD NEXT instructions in README.

@IgnorantGuru
Copy link
Owner Author

The latest change in bb4fe55 looks in eg ~/.local/share/mime/application/pdf.xml to see if there is an icon tag, and if so uses that icon. Otherwise it guesses the icon (which is part of the MIME spec). It no longer walks up the tree looking for generic-icon.

However, it should be noted that SpaceFM is not fully spec-compliant in this area, in that it does not read ~/.local/share/mime/icons or /usr/share/mime/generic-icons, etc. The spec is a bit convoluted to support, and would kill performance. But SpaceFM has been working this way for years with no complaints except for this issue, so I'm taking the route of minimal changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant