From 6d612c0f09669d5871e3ef63775d5e4d6905dc3b Mon Sep 17 00:00:00 2001 From: Mike Wallio Date: Sun, 28 Dec 2025 22:39:19 -0500 Subject: [PATCH] Forward fish_key_bindings for fish 4.3 changes (#6) Fixes the regression with falling through to vi mode in default mode --- functions/_tide_item_character.fish | 5 ++++- functions/fish_prompt.fish | 8 ++++---- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/functions/_tide_item_character.fish b/functions/_tide_item_character.fish index 10bb3244..ab727f32 100644 --- a/functions/_tide_item_character.fish +++ b/functions/_tide_item_character.fish @@ -3,7 +3,9 @@ function _tide_item_character set -q add_prefix || echo -ns ' ' - test "$fish_key_bindings" = fish_default_key_bindings && echo -ns $tide_character_icon || + if test "$fish_key_bindings" = fish_default_key_bindings || test -z "$fish_key_bindings" + echo -ns $tide_character_icon + else switch $fish_bind_mode case insert echo -ns $tide_character_icon @@ -14,4 +16,5 @@ function _tide_item_character case visual echo -ns $tide_character_vi_icon_visual end + end end diff --git a/functions/fish_prompt.fish b/functions/fish_prompt.fish index 994513d3..a367dca8 100644 --- a/functions/fish_prompt.fish +++ b/functions/fish_prompt.fish @@ -41,7 +41,7 @@ function fish_prompt jobs -q && jobs -p | count | read -lx _tide_jobs $fish_path -c \"set _tide_pipestatus \$_tide_pipestatus set _tide_parent_dirs \$_tide_parent_dirs -PATH=\$(string escape \"\$PATH\") CMD_DURATION=\$CMD_DURATION fish_bind_mode=\$fish_bind_mode set $prompt_var (_tide_2_line_prompt)\" & +PATH=\$(string escape \"\$PATH\") CMD_DURATION=\$CMD_DURATION fish_key_bindings=\$fish_key_bindings fish_bind_mode=\$fish_bind_mode set $prompt_var (_tide_2_line_prompt)\" & builtin disown command kill \$_tide_last_pid 2>/dev/null @@ -69,7 +69,7 @@ function fish_prompt jobs -q && jobs -p | count | read -lx _tide_jobs $fish_path -c \"set _tide_pipestatus \$_tide_pipestatus set _tide_parent_dirs \$_tide_parent_dirs -PATH=\$(string escape \"\$PATH\") CMD_DURATION=\$CMD_DURATION fish_bind_mode=\$fish_bind_mode set $prompt_var (_tide_2_line_prompt)\" & +PATH=\$(string escape \"\$PATH\") CMD_DURATION=\$CMD_DURATION fish_key_bindings=\$fish_key_bindings fish_bind_mode=\$fish_bind_mode set $prompt_var (_tide_2_line_prompt)\" & builtin disown command kill \$_tide_last_pid 2>/dev/null @@ -101,7 +101,7 @@ function fish_prompt jobs -q && jobs -p | count | read -lx _tide_jobs $fish_path -c \"set _tide_pipestatus \$_tide_pipestatus set _tide_parent_dirs \$_tide_parent_dirs -PATH=\$(string escape \"\$PATH\") CMD_DURATION=\$CMD_DURATION fish_bind_mode=\$fish_bind_mode set $prompt_var (_tide_1_line_prompt)\" & +PATH=\$(string escape \"\$PATH\") CMD_DURATION=\$CMD_DURATION fish_key_bindings=\$fish_key_bindings fish_bind_mode=\$fish_bind_mode set $prompt_var (_tide_1_line_prompt)\" & builtin disown command kill \$_tide_last_pid 2>/dev/null @@ -128,7 +128,7 @@ function fish_prompt jobs -q && jobs -p | count | read -lx _tide_jobs $fish_path -c \"set _tide_pipestatus \$_tide_pipestatus set _tide_parent_dirs \$_tide_parent_dirs -PATH=\$(string escape \"\$PATH\") CMD_DURATION=\$CMD_DURATION fish_bind_mode=\$fish_bind_mode set $prompt_var (_tide_1_line_prompt)\" & +PATH=\$(string escape \"\$PATH\") CMD_DURATION=\$CMD_DURATION fish_key_bindings=\$fish_key_bindings fish_bind_mode=\$fish_bind_mode set $prompt_var (_tide_1_line_prompt)\" & builtin disown command kill \$_tide_last_pid 2>/dev/null