Fixed hanging if new connection is made after disconnect() call #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiorix
added a commit
that referenced
this pull request
Jan 12, 2016
Fixed hanging if new connection is made after disconnect() call
|
👍 |
|
Is there any plans for 1.4 version? It would be cool to get this fix into PyPI... :) |
|
Yes, doing it now. Going forward I could use some of your help if you don't mind. ;) |
|
Sure :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConnectionPoolmay hang on disconnecting if new connection is made afterdisconnect()call. This new connection is added topool, but it wont disconnect, so pool will never be empty anddisconnect()will never return.This happen often when I run very short unit tests and when not all pool's connections get connected before
disconnect().Fixed by preventing new connections to be added to pool if its
continueTryingis set toFalse.