Skip to content

Nuke13 custom dependencies #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ivanimanishi merged 2 commits into from
May 18, 2022
Merged

Nuke13 custom dependencies #1263

ivanimanishi merged 2 commits into from
May 18, 2022

Conversation

@lucienfostier
Copy link
Contributor

@lucienfostier lucienfostier commented May 12, 2022 •
edited
Loading

Fixes

Update IE options file to support Nuke 13.x custom dependencies.(#1263)

Related Issues

  • List any Issues this PR addresses or solves

Dependencies

  • List any other unmerged PRs that this PR depends on

Breaking Changes

  • List any breaking API/ABI changes

Checklist

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Cortex project's prevailing coding style and conventions.

@lucienfostier
Add support for nuke 13 custom OIIO build
9351f39
@lucienfostier
SConstruct: Prepend OIIO lib path to test env to support custom OIIO …
3aa98e9 
…build.

Nuke 13.2 requires OIIO build with boost 1.70.0 so we need to prepend
the lib path to the LD_LIBRARY_PATH for this custom OIIO build to used
as runtime.
@lucienfostier lucienfostier requested a review from johnhaddon May 12, 2022 18:44
@lucienfostier lucienfostier self-assigned this May 12, 2022
johnhaddon
johnhaddon approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@johnhaddon johnhaddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivanimanishi ivanimanishi merged commit 114e53e into ImageEngine:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnhaddon johnhaddon johnhaddon approved these changes

Assignees

@lucienfostier lucienfostier

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lucienfostier @johnhaddon @ivanimanishi