Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak in WriteSGIImage #1052

Closed
3 tasks done
jgj212 opened this issue Mar 24, 2018 · 2 comments
Closed
3 tasks done

Memory leak in WriteSGIImage #1052

jgj212 opened this issue Mar 24, 2018 · 2 comments
Labels

Comments

@jgj212
Copy link
Contributor

jgj212 commented Mar 24, 2018

Prerequisites

  • I have written a descriptive issue title
  • I have verified that I am using the latest version of ImageMagick
  • I have searched open and closed issues to ensure it has not already been reported

Description

Memory leak in WriteSGIImage

Steps to Reproduce

    pixel_info=AcquireVirtualMemory((size_t) number_pixels,4*					//line 1015, allocation for pixel_info
      iris_info.bytes_per_pixel*sizeof(*pixels));
    if (pixel_info == (MemoryInfo *) NULL)
      ThrowWriterException(ResourceLimitError,"MemoryAllocationFailed");
            if (offsets != (ssize_t *) NULL)
              offsets=(ssize_t *) RelinquishMagickMemory(offsets);
            if (runlength != (size_t *) NULL)
              runlength=(size_t *) RelinquishMagickMemory(runlength);
            if (packet_info != (MemoryInfo *) NULL)
              packet_info=RelinquishVirtualMemory(packet_info);
            ThrowWriterException(ResourceLimitError,"MemoryAllocationFailed");	//line 1132, memory leak as not free pixel_info

System Configuration

  • ImageMagick version: 7.0.7-28
  • Environment (Operating system, version and so on): Ubuntu14.04 x86_64
  • Additional information:

Credit: ADLab of Venustech

@urban-warrior
Copy link
Contributor

Thanks for the problem report. We can reproduce it and will have a patch to fix it in GIT master branch @ https://github.com/ImageMagick/ImageMagick later today. The patch will be available in the beta releases of ImageMagick @ https://www.imagemagick.org/download/beta/ by sometime tomorrow.

@dlemstra dlemstra added the bug label Mar 24, 2018
@nohmask
Copy link

nohmask commented Oct 4, 2018

This was assigned CVE-2018-17965.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants