Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There are two memory leak issues in ReadBMPImage in coder/bmp.c and ReadVIFFImage in coder/viff.c.
There is a patch 3b48d20, which fixed multiple memory leak vulnerabilities.
However, the patch for ReadBMPImage is wrong.
if (GetNextImageInList(image) == (Image *) NULL) { - image=DestroyImageList(image); + status=MagickFalse; return((Image *) NULL); }
Below is the correct logic.
if (GetNextImageInList(image) == (Image *) NULL) { - image=DestroyImageList(image); - return((Image *) NULL); + status=MagickFalse; + break; }
https://github.com/ImageMagick/ImageMagick/blob/master/coders/bmp.c#L1508
At the same time, there is the same issue in ReadVIFFImage.
if (GetNextImageInList(image) == (Image *) NULL) { image=DestroyImageList(image); return((Image *) NULL); }
https://github.com/ImageMagick/ImageMagick/blob/master/coders/viff.c#L774
The text was updated successfully, but these errors were encountered:
https://github.com/ImageMagick/ImageMagick/issues/1600
fe30661
Thanks for the problem report. We can reproduce it and will have a patch to fix it in GIT master branch @ https://github.com/ImageMagick/ImageMagick later today. The patch will be available in the beta releases of ImageMagick @ http://www.imagemagick.org/download/beta/ by sometime tomorrow.
Sorry, something went wrong.
This was assigned CVE-2019-13133 and CVE-2019-13134.
No branches or pull requests
Prerequisites
Description
There are two memory leak issues in ReadBMPImage in coder/bmp.c and ReadVIFFImage in coder/viff.c.
There is a patch 3b48d20, which fixed multiple memory leak vulnerabilities.
However, the patch for ReadBMPImage is wrong.
Below is the correct logic.
https://github.com/ImageMagick/ImageMagick/blob/master/coders/bmp.c#L1508
At the same time, there is the same issue in ReadVIFFImage.
https://github.com/ImageMagick/ImageMagick/blob/master/coders/viff.c#L774
Steps to Reproduce
System Configuration
The text was updated successfully, but these errors were encountered: