Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IM7: add default colorspace_ in combineImages() for backward compatibility #1655

Closed
jeroen opened this issue Aug 2, 2019 · 0 comments

Comments

@jeroen
Copy link
Contributor

commented Aug 2, 2019

In C++ bindings that were written for IM6 we use this:

combineImages(&x, input->begin(), input->end(), MagickCore::AllChannels);

In IM7 the function has gained an additional parameter:

template<class InputIterator >
void combineImages(Image *combinedImage_,InputIterator first_,
InputIterator last_,const ChannelType channel_,
const ColorspaceType colorspace_)

Would it be possible to give colorspace_ parameter a suitable default such that we can use the same C++ code with IM6 and IM7 (and preferably retain the same behavior)?

@dlemstra dlemstra added this to the 7.0.8-59 milestone Aug 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.