Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory-Leak in WriteOnePNGImage() coders/png.c #569

Closed
lcatro opened this issue Jul 16, 2017 · 4 comments

Comments

Projects
None yet
6 participants
@lcatro
Copy link

commented Jul 16, 2017

Memory Leak File Link : https://raw.githubusercontent.com/lcatro/My_PoC/master/ImageMagick/memory-leak_output_png_WriteOnePNGImage

Trigger Command : ./magick convert memory-leak_output_png_WriteOnePNGImage output.png

Leak Detail :

fuzzing@ubuntu:~/fuzzing/ImageMagick/utilities$ ./magick convert memory-leak_output_png_WriteOnePNGImage output.png
convert: UnableToOpenConfigureFile `magic.xml' @ warning/configure.c/GetConfigureOptions/715.

=================================================================
==62838==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 32 byte(s) in 1 object(s) allocated from:
    #0 0x7fa46b846602 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98602)
    #1 0x7fa46ad4f981 in AcquireMagickMemory MagickCore/memory.c:464
    #2 0x7fa46ae6decf in AcquireStringInfo MagickCore/string.c:174
    #3 0x7fa46ae6e979 in CloneStringInfo MagickCore/string.c:330
    #4 0x7fa46b176e9f in WriteOnePNGImage coders/png.c:11581
    #5 0x7fa46b17bd2c in WritePNGImage coders/png.c:12536
    #6 0x7fa46abab1c6 in WriteImage MagickCore/constitute.c:1114
    #7 0x7fa46ababe42 in WriteImages MagickCore/constitute.c:1333
    #8 0x7fa46a3fe3eb in ConvertImageCommand MagickWand/convert.c:3280
    #9 0x7fa46a4f6d98 in MagickCommandGenesis MagickWand/mogrify.c:183
    #10 0x4017f1 in MagickMain utilities/magick.c:149
    #11 0x4019d2 in main utilities/magick.c:180
    #12 0x7fa469c6b82f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)

Indirect leak of 4116 byte(s) in 1 object(s) allocated from:
    #0 0x7fa46b846602 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98602)
    #1 0x7fa46ad4f981 in AcquireMagickMemory MagickCore/memory.c:464
    #2 0x7fa46ad4f9d5 in AcquireQuantumMemory MagickCore/memory.c:537
    #3 0x7fa46ae6e084 in AcquireStringInfo MagickCore/string.c:182
    #4 0x7fa46ae6e979 in CloneStringInfo MagickCore/string.c:330
    #5 0x7fa46b176e9f in WriteOnePNGImage coders/png.c:11581
    #6 0x7fa46b17bd2c in WritePNGImage coders/png.c:12536
    #7 0x7fa46abab1c6 in WriteImage MagickCore/constitute.c:1114
    #8 0x7fa46ababe42 in WriteImages MagickCore/constitute.c:1333
    #9 0x7fa46a3fe3eb in ConvertImageCommand MagickWand/convert.c:3280
    #10 0x7fa46a4f6d98 in MagickCommandGenesis MagickWand/mogrify.c:183
    #11 0x4017f1 in MagickMain utilities/magick.c:149
    #12 0x4019d2 in main utilities/magick.c:180
    #13 0x7fa469c6b82f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)

SUMMARY: AddressSanitizer: 4148 byte(s) leaked in 2 allocation(s).

@mikayla-grace

This comment has been minimized.

Copy link

commented Jul 16, 2017

Thanks for the problem report. We can reproduce it and will have a patch to fix it in GIT master branch @ https://github.com/ImageMagick/ImageMagick later today. The patch will be available in the beta releases of ImageMagick @ http://www.imagemagick.org/download/beta/ by sometime tomorrow.

dlemstra pushed a commit that referenced this issue Jul 16, 2017

Cristy

@dlemstra dlemstra added the bug label Jul 16, 2017

@dlemstra dlemstra closed this Jul 16, 2017

@bastien-roucaries

This comment has been minimized.

Copy link

commented Jul 26, 2017

Is is a V6 problem ?

@glennrp

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2017

IM6 was fixed the same day, commit 0a80c9e

@parr0tr1ver

This comment has been minimized.

Copy link

commented Sep 12, 2017

It should fixed in V7 by commit e436a58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.