Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPU exhaustion in ReadPDBImage #604

Closed
bestshow opened this issue Jul 23, 2017 · 2 comments
Closed

CPU exhaustion in ReadPDBImage #604

bestshow opened this issue Jul 23, 2017 · 2 comments
Labels

Comments

@bestshow
Copy link

Version: ImageMagick 7.0.6-2 Q16 x86_64
#./convert $FILE OUT.png
When convert PDB file , imagemagick will read data from input file and deal with it, here is the critical code:
pdb.c , in function ReadPDBImage:

      comment_offset=(ssize_t) ReadBlobMSBSignedLong(image); //365
      ......
      num_pad_bytes = (size_t) (comment_offset - TellBlob( image ));
      while (num_pad_bytes--) ReadBlobByte( image );  //574

A crafted file will cause this while loop endless.
testcase: https://github.com/bestshow/p0cs/blob/master/cpupdb.pdb
Credit : ADLab of Venustech

@mikayla-grace
Copy link

Thanks for the problem report. We can reproduce it and will have a patch to fix it in GIT master branch @ https://github.com/ImageMagick/ImageMagick later today. The patch will be available in the beta releases of ImageMagick @ http://www.imagemagick.org/download/beta/ by sometime tomorrow.

@nohmask
Copy link

nohmask commented Sep 8, 2017

This was assigned CVE-2017-12674.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants