Fix abort when writing to rgf format #223

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@dlech
Contributor

dlech commented Jun 19, 2016

The rgf format (LEGO MINDSTORMS EV3 images) caused a software abort because
exception == NULL. When WriteRGFImage is called from WriteImage, it is only
passed two parameters, not three. So, removed the extra parameter and use
image->exception instead as in other coders.

Fix abort when writing to rgf format
The rgf format (LEGO MINDSTORMS EV3 images) caused a software abort because
exception == NULL. When WriteRGFImage is called from WriteImage, it is only
passed two parameters, not three. So, removed the extra parameter and use
image->exception instead as in other coders.
@dlech

This comment has been minimized.

Show comment
Hide comment
@dlech

dlech Jun 19, 2016

Contributor

This patch is tested working on Ubuntu 16.04

Contributor

dlech commented Jun 19, 2016

This patch is tested working on Ubuntu 16.04

@dlemstra

This comment has been minimized.

Show comment
Hide comment
@dlemstra

dlemstra Jun 19, 2016

Member

Good catch 👍 Your commit has been cherry picked (a0108a8) and this fix will be available in the next release (6.9.4-10).

Member

dlemstra commented Jun 19, 2016

Good catch 👍 Your commit has been cherry picked (a0108a8) and this fix will be available in the next release (6.9.4-10).

@dlemstra dlemstra closed this Jun 19, 2016

dlech added a commit to ev3dev/lms2012-compat that referenced this pull request Jun 22, 2016

Get rid of lmsbmp bitmap converter
ImageMagick has supported rgf format since Aug 2013 so this is
not needed (we are already using imagemagick convert for xbm anyway)

Note, there is a bug in ImageMagick 6 that causes a software abort when
writing the rgf format, so you will need a patched version.

ImageMagick/ImageMagick#223
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=827643
https://bugs.launchpad.net/debian/+source/imagemagick/+bug/1594060
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment