Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix abort when writing to rgf format #223

Closed
wants to merge 1 commit into from

Conversation

dlech
Copy link
Contributor

@dlech dlech commented Jun 19, 2016

The rgf format (LEGO MINDSTORMS EV3 images) caused a software abort because
exception == NULL. When WriteRGFImage is called from WriteImage, it is only
passed two parameters, not three. So, removed the extra parameter and use
image->exception instead as in other coders.

The rgf format (LEGO MINDSTORMS EV3 images) caused a software abort because
exception == NULL. When WriteRGFImage is called from WriteImage, it is only
passed two parameters, not three. So, removed the extra parameter and use
image->exception instead as in other coders.
@dlech
Copy link
Contributor Author

dlech commented Jun 19, 2016

This patch is tested working on Ubuntu 16.04

@dlemstra
Copy link
Member

Good catch 👍 Your commit has been cherry picked (a0108a8) and this fix will be available in the next release (6.9.4-10).

@dlemstra dlemstra closed this Jun 19, 2016
dlech added a commit to ev3dev/lms2012-compat that referenced this pull request Jun 22, 2016
ImageMagick has supported rgf format since Aug 2013 so this is
not needed (we are already using imagemagick convert for xbm anyway)

Note, there is a bug in ImageMagick 6 that causes a software abort when
writing the rgf format, so you will need a patched version.

ImageMagick/ImageMagick#223
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=827643
https://bugs.launchpad.net/debian/+source/imagemagick/+bug/1594060
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants